Skip Menu |
 

This queue is for tickets about the Net-DNS-SEC CPAN distribution.

Report information
The Basics
Id: 62387
Status: resolved
Priority: 0/
Queue: Net-DNS-SEC

People
Owner: Nobody in particular
Requestors: 1fea [...] packet-pushers.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.16
Fixed in: (no value)



Subject: Some minor typos
A few typos that I happened to notice:
Subject: typos.patch
Download typos.patch
text/x-diff 3.7k
Index: RR/DS.pm =================================================================== --- RR/DS.pm (revision 861) +++ RR/DS.pm (working copy) @@ -25,7 +25,7 @@ $VERSION = do { my @r=(q$Revision$=~/\d+/g); sprintf "%d."."%03d"x$#r,@r }; my $debug=0; -@ISA = qw(Net::DNS::RR); +@ISA = qw(Net::DNS::RR Net::DNS::SEC); sub new { my ($class, $self, $data, $offset) = @_; Index: RR/RRSIG.pm =================================================================== --- RR/RRSIG.pm (revision 861) +++ RR/RRSIG.pm (working copy) @@ -608,7 +608,7 @@ } else # Verifying other algorithms { - $self->{"vrfyerrstr"}= "Algoritm ". $self->algorithm . " has not yet been implemented"; + $self->{"vrfyerrstr"}= "Algorithm ". $self->algorithm . " has not yet been implemented"; return 0; } @@ -1209,7 +1209,7 @@ print "signame =", $rr->signame, "\n" -Returns the name of the public KEY RRs this sig was made with. +Returns the name of the public DNSKEY RRs this sig was made with. =head2 sig Index: RR/DNSKEY.pm =================================================================== --- RR/DNSKEY.pm (revision 861) +++ RR/DNSKEY.pm (working copy) @@ -324,7 +324,7 @@ For RSA this method returns the length (in bits) of the modulus. -For DSA this method returnse the value of the T parameter (See RFC2536) +For DSA this method returns the value of the T parameter (See RFC2536) Returns -1 if the keysize cannot be determined (e.g. for unknown algorithms algorithm). Index: RR/SIG.pm =================================================================== --- RR/SIG.pm (revision 861) +++ RR/SIG.pm (working copy) @@ -654,7 +654,7 @@ } else # Verifying other algorithms { - $self->{"vrfyerrstr"}= "Algoritm ". $self->algorithm . " has not yet been implemented"; + $self->{"vrfyerrstr"}= "Algorithm ". $self->algorithm . " has not yet been implemented"; return 0; } Index: SEC.pm =================================================================== --- SEC.pm (revision 861) +++ SEC.pm (working copy) @@ -142,7 +142,7 @@ $memonic=$self->digtype("mnemonic"); -The algorithm method is used to set or read the value of the digest or +The digtype method is used to set or read the value of the digestype or hash algorithm field in Net::DNS::RR::DS and Net::DNS::RR::NSEC3 objects. @@ -300,39 +300,39 @@ if (!defined $argument){ return if $classmethod; - return $self->{"digest"}; + return $self->{"digtype"}; } # Argument has some value... $argument =~ s/\s//g; # Remove strings to be kind if ($argument =~ /^\d+$/ ){ #Numeric argument. - carp "$argument does not map to a valid digest" unless + carp "$argument does not map to a valid digest type" unless exists $digestbyval{$argument}; if ($classmethod){ return $argument ; }else{ - return $self->{"digest"}=$argument ; + return $self->{"digtype"}=$argument ; } }else{ # argument is not numeric if ($classmethod){ - carp "$argument does not map to a valid digest" unless + carp "$argument does not map to a valid digest type" unless exists $digestbyname{uc($argument)}; return $digestbyname{uc($argument)}; }else{ # Not a class method.. if (lc($argument) eq "mnemonic"){ - return $digestbyval{$self->{"digest"}}; + return $digestbyval{$self->{"digtype"}}; }else{ - carp "$argument does not map to a valid digest" unless + carp "$argument does not map to a valid digest type" unless exists $digestbyname{uc($argument)}; - return $self->{"digest"}=$digestbyname{uc($argument)}; + return $self->{"digtype"}=$digestbyname{uc($argument)}; } } } - die "digest method should never end here"; + die "digtype method should never end here"; }
From: 1fea [...] packet-pushers.com
Download (untitled) / with headers
text/plain 172b
On Fri Oct 22 18:20:20 2010, wessels wrote: Show quoted text
> A few typos that I happened to notice: >
whoops, sorry the patch above contains more than typos. Here are just the typos
Subject: typos.patch
Download typos.patch
text/x-diff 1.5k
Index: RR/RRSIG.pm =================================================================== --- RR/RRSIG.pm (revision 861) +++ RR/RRSIG.pm (working copy) @@ -608,7 +608,7 @@ } else # Verifying other algorithms { - $self->{"vrfyerrstr"}= "Algoritm ". $self->algorithm . " has not yet been implemented"; + $self->{"vrfyerrstr"}= "Algorithm ". $self->algorithm . " has not yet been implemented"; return 0; } @@ -1209,7 +1209,7 @@ print "signame =", $rr->signame, "\n" -Returns the name of the public KEY RRs this sig was made with. +Returns the name of the public DNSKEY RRs this sig was made with. =head2 sig Index: RR/DNSKEY.pm =================================================================== --- RR/DNSKEY.pm (revision 861) +++ RR/DNSKEY.pm (working copy) @@ -324,7 +324,7 @@ For RSA this method returns the length (in bits) of the modulus. -For DSA this method returnse the value of the T parameter (See RFC2536) +For DSA this method returns the value of the T parameter (See RFC2536) Returns -1 if the keysize cannot be determined (e.g. for unknown algorithms algorithm). Index: RR/SIG.pm =================================================================== --- RR/SIG.pm (revision 861) +++ RR/SIG.pm (working copy) @@ -654,7 +654,7 @@ } else # Verifying other algorithms { - $self->{"vrfyerrstr"}= "Algoritm ". $self->algorithm . " has not yet been implemented"; + $self->{"vrfyerrstr"}= "Algorithm ". $self->algorithm . " has not yet been implemented"; return 0; }
Applied, Thanks. -- Willem


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.