Skip Menu |
 

This queue is for tickets about the WWW-Ohloh-API CPAN distribution.

Report information
The Basics
Id: 62023
Status: open
Priority: 0/
Queue: WWW-Ohloh-API

People
Owner: yanick+cpan [...] babyl.dyndns.org
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.0_1
Fixed in: (no value)



Subject: Fails with Test::More > 0.94
As per subject. I just verified with some of my smokers: upgrading from Test::More 0.94 to 0.95_01 or higher breaks your test suite. It is the overloading test. The following change makes the test pass again (BUT this is not the fix!): --- t/02-account.t~ 2010-10-10 06:37:56.000000000 +0200 +++ t/02-account.t 2010-10-10 06:36:22.000000000 +0200 @@ -12,7 +12,7 @@ my $account = $ohloh->fetch_account(12933); -is $account => 'Yanick', 'overloading'; +is "$account" => 'Yanick', 'overloading'; like $account->as_xml => qr# ^ \s* <account> .* </account> \s* $ #sx, 'as_xml()'; This indicates that the overloading in the package has no fallback to stringification when somebody tests for equality with 'eq'. So this is the real fix: --- lib/WWW/Ohloh/API/Account.pm~ 2010-10-10 06:42:30.000000000 +0200 +++ lib/WWW/Ohloh/API/Account.pm 2010-10-10 06:44:34.000000000 +0200 @@ -18,7 +18,7 @@ our $VERSION = '1.0_1'; -use overload '""' => sub { $_[0]->name }; +use overload '""' => sub { $_[0]->name }, fallback => 1; #<<< my @id_of : Field HTH, Best wishes,
Subject: Re: [rt.cpan.org #62023] Fails with Test::More > 0.94
Date: Sun, 10 Oct 2010 09:54:34 -0400
To: bug-WWW-Ohloh-API [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
Download (untitled) / with headers
text/plain 396b
On 10/10/2010 12:45 AM, Andreas Koenig via RT wrote: Show quoted text
> I just verified with some of my smokers: upgrading from Test::More 0.94 > to 0.95_01 or higher breaks your test suite.
Ah, that would explain the sudden barrage of test failures. :-) Thanks for root causing the problem. I'll jump on that as soon as I have some round tuits to thrown in the direction of WWW::Ohloh::API. Joy, `/anick
From: reinpost [...] win.tue.nl
Download (untitled) / with headers
text/plain 509b
On Sun Oct 10 09:54:39 2010, yanick@babyl.dyndns.org wrote: Show quoted text
> Thanks for root causing the problem. I'll jump on that as soon as I > have some round tuits to thrown in the direction of WWW::Ohloh::API.
It's June 25, 2012 and I just ran into the same issue. Still just this one test failing. Would love to see this fixed. (It also helps to add the line use overload 'cmp' => sub { $_[0]->name cmp $_[1] }; but not having seen overloads in Perl before, I'm not sure whether that is OK as a fix.
Subject: Re: [rt.cpan.org #62023] Fails with Test::More > 0.94
Date: Tue, 26 Jun 2012 11:38:13 -0400
To: bug-WWW-Ohloh-API [...] rt.cpan.org
From: Yanick Champoux <yanick.champoux [...] gmail.com>
Download (untitled) / with headers
text/plain 940b
On 12-06-25 01:52 PM, Reinier Post via RT wrote: Show quoted text
> Queue: WWW-Ohloh-API > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=62023> > > On Sun Oct 10 09:54:39 2010, yanick@babyl.dyndns.org wrote: >
> > Thanks for root causing the problem. I'll jump on that as soon as I > > have some round tuits to thrown in the direction of WWW::Ohloh::API.
> > It's June 25, 2012 and I just ran into the same issue. Still just this > one test failing. Would love to see this fixed.
*head hangs low in shame* Yesterday, I poured a few hours into the work for converting the module to Moose. If you are interested to help, the branch is at https://github.com/yanick/www-ohloh-api/tree/rewrite and so far I'm working to get t/02account.t passing as a first step. Or you want to fork and just patch the current version to make the test pass, I'll gladly release it to tide you over till the port is done. Joy, `/anick
Subject: Re: [rt.cpan.org #62023] Fails with Test::More > 0.94
Date: Tue, 26 Jun 2012 11:50:29 -0400
To: bug-WWW-Ohloh-API [...] rt.cpan.org
From: Yanick Champoux <yanick.champoux [...] gmail.com>
Download (untitled) / with headers
text/plain 286b
On 12-06-25 01:52 PM, Reinier Post via RT wrote: Show quoted text
> It's June 25, 2012 and I just ran into the same issue. Still just this > one test failing. Would love to see this fixed. >
I've created a branch that takes care of the immediate problem. I'll try to release it tonight. `/.
Subject: Re: [rt.cpan.org #62023] Fails with Test::More > 0.94
Date: Thu, 28 Jun 2012 21:17:13 -0400
To: bug-WWW-Ohloh-API [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
Download (untitled) / with headers
text/plain 179b
On 12-06-26 11:50 AM, Yanick Champoux via RT wrote: Show quoted text
> I'll try to release it tonight.
And it was released. Now, to focus on that Moose port and get it done. :-) Enjoy! `/anick


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.