Skip Menu |
 

This queue is for tickets about the Catalyst-Engine-Apache CPAN distribution.

Report information
The Basics
Id: 61704
Status: resolved
Priority: 0/
Queue: Catalyst-Engine-Apache

People
Owner: bobtfish [...] bobtfish.net
Requestors: tleffler [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.12
Fixed in: (no value)



Subject: Fixed broken tests
Download (untitled) / with headers
text/plain 435b
Attached is a patch file that fixes the following broken tests: - 03podcoverage.t (while TEST_POD=1) - added and modified various pod - live_component_controller_action_streaming.t - updated to use a file that actually exists - live_engine_response_cookies.t - updated to expect lowercased cookie keys The test environment is: - Catalyst-Engine-Apache 1.12 - RHEL 5.4 - perl 5.8.8 - Catalyst-Runtime 5.80022
Subject: fixtests.diff
Download fixtests.diff
text/x-diff 4.4k
diff -uNr Catalyst-Engine-Apache-1.12.orig/lib/Catalyst/Engine/Apache2/MP20.pm Catalyst-Engine-Apache-1.12.fixtests/lib/Catalyst/Engine/Apache2/MP20.pm --- Catalyst-Engine-Apache-1.12.orig/lib/Catalyst/Engine/Apache2/MP20.pm 2007-09-14 09:42:59.000000000 -0700 +++ Catalyst-Engine-Apache-1.12.fixtests/lib/Catalyst/Engine/Apache2/MP20.pm 2010-09-23 16:43:54.000000000 -0700 @@ -99,6 +99,16 @@ =head2 ok_constant +=head1 OVERLOADED METHODS + +This class overloads some methods from C<Catalyst::Engine>. + +=over 4 + +=item unescape_uri + +=back + =head1 SEE ALSO L<Catalyst>, L<Catalyst::Engine>, L<Catalyst::Engine::Apache2>. diff -uNr Catalyst-Engine-Apache-1.12.orig/lib/Catalyst/Engine/Apache2.pm Catalyst-Engine-Apache-1.12.fixtests/lib/Catalyst/Engine/Apache2.pm --- Catalyst-Engine-Apache-1.12.orig/lib/Catalyst/Engine/Apache2.pm 2006-04-07 14:25:33.000000000 -0700 +++ Catalyst-Engine-Apache-1.12.fixtests/lib/Catalyst/Engine/Apache2.pm 2010-09-23 16:40:58.000000000 -0700 @@ -40,7 +40,7 @@ =over 4 -=item $c->engine->finalize_headers +=item finalize_headers =back diff -uNr Catalyst-Engine-Apache-1.12.orig/lib/Catalyst/Engine/Apache.pm Catalyst-Engine-Apache-1.12.fixtests/lib/Catalyst/Engine/Apache.pm --- Catalyst-Engine-Apache-1.12.orig/lib/Catalyst/Engine/Apache.pm 2008-02-20 05:41:43.000000000 -0800 +++ Catalyst-Engine-Apache-1.12.fixtests/lib/Catalyst/Engine/Apache.pm 2010-09-23 16:40:46.000000000 -0700 @@ -307,23 +307,23 @@ =over 4 -=item $c->engine->prepare_request($r) +=item prepare_request($r) -=item $c->engine->prepare_connection +=item prepare_connection -=item $c->engine->prepare_query_parameters +=item prepare_query_parameters -=item $c->engine->prepare_headers +=item prepare_headers -=item $c->engine->prepare_path +=item prepare_path -=item $c->engine->read_chunk +=item read_chunk -=item $c->engine->finalize_body +=item finalize_body -=item $c->engine->finalize_headers +=item finalize_headers -=item $c->engine->write +=item write =back diff -uNr Catalyst-Engine-Apache-1.12.orig/t/lib/TestApp/Controller/Action/Streaming.pm Catalyst-Engine-Apache-1.12.fixtests/t/lib/TestApp/Controller/Action/Streaming.pm --- Catalyst-Engine-Apache-1.12.orig/t/lib/TestApp/Controller/Action/Streaming.pm 2006-10-17 19:08:11.000000000 -0700 +++ Catalyst-Engine-Apache-1.12.fixtests/t/lib/TestApp/Controller/Action/Streaming.pm 2010-09-23 16:49:43.000000000 -0700 @@ -17,7 +17,7 @@ sub body : Local { my ( $self, $c ) = @_; - my $file = "$FindBin::Bin/01use.t"; + my $file = "$FindBin::Bin/02pod.t"; my $fh = IO::File->new( $file, 'r' ); if ( defined $fh ) { $c->res->body( $fh ); diff -uNr Catalyst-Engine-Apache-1.12.orig/t/lib/TestApp/Controller/Engine/Response/Cookies.pm Catalyst-Engine-Apache-1.12.fixtests/t/lib/TestApp/Controller/Engine/Response/Cookies.pm --- Catalyst-Engine-Apache-1.12.orig/t/lib/TestApp/Controller/Engine/Response/Cookies.pm 2006-10-17 19:08:10.000000000 -0700 +++ Catalyst-Engine-Apache-1.12.fixtests/t/lib/TestApp/Controller/Engine/Response/Cookies.pm 2010-09-27 10:43:19.000000000 -0700 @@ -1,6 +1,7 @@ package TestApp::Controller::Engine::Response::Cookies; use strict; +use warnings; use base 'Catalyst::Base'; sub one : Local { diff -uNr Catalyst-Engine-Apache-1.12.orig/t/live_component_controller_action_streaming.t Catalyst-Engine-Apache-1.12.fixtests/t/live_component_controller_action_streaming.t --- Catalyst-Engine-Apache-1.12.orig/t/live_component_controller_action_streaming.t 2007-09-14 09:34:09.000000000 -0700 +++ Catalyst-Engine-Apache-1.12.fixtests/t/live_component_controller_action_streaming.t 2010-09-23 16:46:37.000000000 -0700 @@ -54,7 +54,7 @@ skip "Using remote server", 5; } - my $file = "$FindBin::Bin/01use.t"; + my $file = "$FindBin::Bin/02pod.t"; my $fh = IO::File->new( $file, 'r' ); my $buffer; if ( defined $fh ) { diff -uNr Catalyst-Engine-Apache-1.12.orig/t/live_engine_response_cookies.t Catalyst-Engine-Apache-1.12.fixtests/t/live_engine_response_cookies.t --- Catalyst-Engine-Apache-1.12.orig/t/live_engine_response_cookies.t 2007-09-14 09:34:09.000000000 -0700 +++ Catalyst-Engine-Apache-1.12.fixtests/t/live_engine_response_cookies.t 2010-09-23 16:58:18.000000000 -0700 @@ -11,8 +11,8 @@ use HTTP::Headers::Util 'split_header_words'; my $expected = { - Catalyst => [qw|Catalyst Cool path /bah|], - Cool => [qw|Cool Catalyst path /|] + catalyst => [qw|catalyst Cool path /bah|], + cool => [qw|cool Catalyst path /|] }; {
Download (untitled) / with headers
text/plain 127b
(Partially) applied as r13612. The t/lib is an svn external, so I'll just pull in the new version instead which has changed :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.