This queue is for tickets about the Digest-CRC CPAN distribution.

Report information
The Basics
Id:
61491
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
OLIMAUL [...] cpan.org
Requestors:
RBS [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
0.15
Fixed in:
(no value)



Subject: CRC.xs warning, test failure in crc64()
When building on strawberry perl 5.12.1 (which uses gcc (GCC) 4.4.3), I see the warning CRC.xs: In function 'XS_Digest__CRC__crc64': CRC.xs:157: warning: integer constant is too large for 'long' type and the crc64() test fails. I don't need crc64(), so this is not a critical issue for me. Perl -V output: Summary of my perl5 (revision 5 version 12 subversion 1) configuration: Platform: osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread uname='Win32 strawberryperl 5.12.1.0 #1 Thu Jul 29 10:08:11 2010 i386' config_args='undef' hint=recommended, useposix=true, d_sigaction=undef useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='gcc', ccflags =' -s -O2 -DWIN32 -DHAVE_DES_FCRYPT - DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -f no-strict-aliasing -mms-bitfields -DPERL_MSVCRT_READFIX', optimize='-s -O2', cppflags='-DWIN32' ccversion='', gccversion='4.4.3', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='long long', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='g++', ldflags ='-s -L"C:\strawberry\perl\lib\CORE" - L"C:\strawberry\c\lib"' libpth=C:\strawberry\c\lib C:\strawberry\c\i686-w64-mingw32\lib libs=-lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 - ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luu id -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32 -lcomctl32 perllibs=-lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool - lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32 -lcomctl32 libc=, so=dll, useshrplib=true, libperl=libperl512.a gnulibc_version='' Dynamic Linking: dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags='-mdll -s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"' Characteristics of this binary (from libperl): Compile-time options: MULTIPLICITY PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS PERL_MALLOC_WRAP PL_OP_SLAB_ALLOC USE_ITHREADS USE_LARGE_FILES USE_PERLIO USE_PERL_ATOF USE_SITECUSTOMIZE Built under MSWin32 Compiled at Jul 29 2010 16:46:09 %ENV: PERL5_CPANPLUS_IS_RUNNING="3200" PERL5_CPAN_IS_RUNNING="3200" @INC: C:/strawberry/perl/site/lib C:/strawberry/perl/vendor/lib C:/strawberry/perl/lib .
can you please add the patch 157,158c157,158 < unsigned long long poly64rev = 0xd800000000000000; < unsigned long long crc = 0x0000000000000000; ---
Show quoted text
> unsigned long long poly64rev = 0xd800000000000000ULL; > unsigned long long crc = 0x0000000000000000ULL;
to CRC.xs and tell me the result of the crc64 test. Oliver
Subject: Re: [rt.cpan.org #61491] CRC.xs warning, test failure in crc64()
Date: Tue, 21 Sep 2010 07:54:54 -0400
To: bug-Digest-CRC@rt.cpan.org
From: Barrie Slaymaker <barries@slaysys.com>
Fixes the compiler warning, test output: not ok 2 - crc64 2321281022 # Failed test 'crc64 2321281022' # at t/crc.t line 27. - Barrie On 9/21/2010 2:39 AM, Oliver Maul via RT wrote:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=61491> > > can you please add the patch > > 157,158c157,158 > < unsigned long long poly64rev = 0xd800000000000000; > < unsigned long long crc = 0x0000000000000000; > ---
>> unsigned long long poly64rev = 0xd800000000000000ULL; >> unsigned long long crc = 0x0000000000000000ULL;
> to CRC.xs and tell me the result of the crc64 test. > > > Oliver


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.