Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 6133
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: blair [...] orcaware.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Module::Build 0.25 fails make test with Perl 5.005_03
Download (untitled) / with headers
text/plain 16.3k

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 1.3k
Hi, I think the following patch should fix it - care to try it out? -Ken Index: lib/Module/Build/Base.pm ========================================================= ========== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.290 diff -u -r1.290 Base.pm --- lib/Module/Build/Base.pm 15 Apr 2004 20:47:08 -0000 1.290 +++ lib/Module/Build/Base.pm 27 Apr 2004 04:42:29 -0000 @@ -1453,7 +1453,6 @@ sub htmlify_pods { my $self = shift; - require Pod::Html; require Module::Build::PodParser; my $blib = $self->blib; @@ -1486,6 +1485,7 @@ sub _htmlify_pod { my ($self, %args) = @_; + require Pod::Html; my ($name, $path) = File::Basename::fileparse($args{rel_path}, qr{\..*}); my @dirs = File::Spec->splitdir($path); @@ -1514,18 +1514,17 @@ my $abstract = Module::Build::PodParser->new(fh => $fh)->get_abstract(); $title .= " - $abstract" if $abstract; } - + my $blib = $self->blib; my @opts = ( - '--header', '--flush', - "--backlink=$args{backlink}", "--title=$title", "--podpath=$podpath", "--infile=$infile", "--outfile=$outfile", "--podroot=$blib", "--htmlroot=$htmlroot", + Pod::Html->VERSION >= 1.03 ? ('--header', "--backlink=$args{backlink}") : (), ); push @opts, "--css=$path2root/$args{css}" if $args{css};
I believe I've fixed those warnings in CVS now too, thanks. -Ken
From: blair [...] orcaware.com
Download (untitled) / with headers
text/plain 287b
[KWILLIAMS - Wed Apr 28 18:11:51 2004]: Show quoted text
> I believe I've fixed those warnings in CVS now too, thanks. > > -Ken
I don't know if you got my email stating that the above patch worked. The email didn't end up in this ticket. Good to hear that the warnings are going away. Best, Blair


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.