Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 61241
Status: open
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: SGRAHAM [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.3607
Fixed in: (no value)



Subject: Generated MANIFEST.SKIP contains duplicates, provoking Test::DistManifest warnings
Download (untitled) / with headers
text/plain 1.1k
The MANIFEST.SKIP generated if you do not have one, contains duplicate lines, which provokes warnings from Test::DistManifest: t/95-manifest.t ........ 1/4 Duplicate file or mask ^MYMETA\. at /usr/local/share/perl/5.10.1/Test/DistManifest.pm line 211 Duplicate file or mask \bBuild$ at /usr/local/share/perl/5.10.1/Test/DistManifest.pm line 211 Duplicate file or mask \bBuild.bat$ at /usr/local/share/perl/5.10.1/Test/DistManifest.pm line 211 Duplicate file or mask \bBuild.COM$ at /usr/local/share/perl/5.10.1/Test/DistManifest.pm line 211 Duplicate file or mask \bBUILD.COM$ at /usr/local/share/perl/5.10.1/Test/DistManifest.pm line 211 Duplicate file or mask \bbuild.com$ at /usr/local/share/perl/5.10.1/Test/DistManifest.pm line 211 Whether the fault lies in Module::Build or Test::DistManifest I couldn't say, however patching Module::Build seems likely to provide a more effective way to fix the issue since that module version is under the control of the distribution author rather than the end-user. Flagged as unimportant since you can manually edit the MANIFEST.SKIP to remove the duplicates, and it's only warnings rather than test failures.
Download (untitled) / with headers
text/plain 273b
(apologies for a very tardy response) It seems like the examples are all case variations -- I don't think MANIFEST.SKIP is applied case-insensitively, so I think that's a bug in Test::DistManifest not to allow 'BUILD' vs 'build'. I'm going to close this ticket. -- David
Download (untitled) / with headers
text/plain 863b
Thanks for the response, I've reopened because the previous close was a misunderstanding based on my poor description of the problem. The problem isn't the multiple case checks, rather there's exact duplicate lines: # Avoid Module::Build generated and utility files. \bBuild$ \b_build/ \bBuild.bat$ \bBuild.COM$ \bBUILD.COM$ \bbuild.com$ then further down in the MANIFEST.SKIP there is a repeat: #!end included /usr/local/share/perl/5.10.1/ExtUtils/MANIFEST.SKIP # Avoid configuration metadata file ^MYMETA\. # Avoid Module::Build generated and utility files. \bBuild$ \bBuild.bat$ \b_build \bBuild.COM$ \bBUILD.COM$ \bbuild.com$ ^MANIFEST\.SKIP It's the exact duplicates that cause the issue, rather than the Build vs BUILD regexps. I've attached a generated MANIFEST.SKIP that shows the problem and apologies for the poor description in the first place.
Subject: MANIFEST.SKIP
Download MANIFEST.SKIP
application/octet-stream 1.1k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #61241] Generated MANIFEST.SKIP contains duplicates, provoking Test::DistManifest warnings
Date: Tue, 25 Jan 2011 11:49:04 -0500
To: bug-Module-Build [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 961b
On Tue, Jan 25, 2011 at 10:56 AM, Sam Graham via RT <bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> Thanks for the response, I've reopened because the previous close was a > misunderstanding based on my poor description of the problem. > > The problem isn't the multiple case checks, rather there's exact > duplicate lines:
I see. I've reviewed the code and see that the issue is that M::B includes whatever defaults are provided by ExtUtils::Manifest, but on a sufficiently old EU::Manifest, it needs to include the M::B entries, whereas on a newer EU::Manifest, it doesn't. Ultimately, I think that Test::Distmanifest is being unnecessarily strict about duplicate entries in MANIFEST.SKIP. I'll leave this ticket open, but low priority and someone may get around to patching it in the future. (Note to future patcher: in Module::Build::Base::_write_default_maniskip(), filter any duplicate lines before writing the file, ideally, preserving comments.) -- David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.