Skip Menu |
 

This queue is for tickets about the Search-Sitemap CPAN distribution.

Report information
The Basics
Id: 61197
Status: open
Priority: 0/
Queue: Search-Sitemap

People
Owner: Nobody in particular
Requestors: AJGB [...] cpan.org
cjm [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.10
Fixed in: (no value)



Subject: Search::Sitemap 2.11 on github
Download (untitled) / with headers
text/plain 490b
Hi, I've fixed following bugs: 60498 Moose changes cause warning about attribute coercion 59038 $map->add() doesn't accept a DateTime object for lastmod 57260 small documentation bug 57240 Search::Sitemap::Index object can't be created 57231 minor documentation bug 56964 Can't update() a URL's priority 52742 read() seems not to read It's available on http://github.com/ajgb/search-sitemap as version 2.11. There are separate commits for each bug. Regards, Alex J. G. Burzyński
Subject: Re: [rt.cpan.org #61197] Search::Sitemap 2.11 on github
Date: Tue, 21 Sep 2010 13:31:02 -0400
To: bug-Search-Sitemap [...] rt.cpan.org
From: Jason Kohles <email [...] jasonkohles.com>
Download (untitled) / with headers
text/plain 1.1k
Thanks, this is the largest patch anybody has ever sent me for one of my modules! Sorry it took so long for me to respond, I've been out of town. I'll work on getting a new release out with your fixes ASAP. Thanks again! On Sep 9, 2010, at 6:32 AM, Alex J. G. Burzynski via RT wrote: Show quoted text
> Thu Sep 09 06:32:55 2010: Request 61197 was acted upon. > Transaction: Ticket created by AJGB > Queue: Search-Sitemap > Subject: Search::Sitemap 2.11 on github > Broken in: 2.10 > Severity: (no value) > Owner: Nobody > Requestors: AJGB@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > > > > Hi, > > I've fixed following bugs: > 60498 Moose changes cause warning about attribute coercion > 59038 $map->add() doesn't accept a DateTime object for lastmod > 57260 small documentation bug > 57240 Search::Sitemap::Index object can't be created > 57231 minor documentation bug > 56964 Can't update() a URL's priority > 52742 read() seems not to read > > It's available on http://github.com/ajgb/search-sitemap as version 2.11. > > There are separate commits for each bug. > > Regards, > Alex J. G. Burzyński >
Download (untitled) / with headers
text/plain 1.4k
Hi Jason, My offer to help you with maintaining this module still holds. Search::Sitemap is a great piece of work and I'm really keen on bringing it alive again. Regards, Alex On Tue Sep 21 13:31:12 2010, email@jasonkohles.com wrote: Show quoted text
> Thanks, this is the largest patch anybody has ever sent me for one of > my modules! Sorry it took so long for me to respond, I've been out of > town. I'll work on getting a new release out with your fixes ASAP. > > Thanks again! > > On Sep 9, 2010, at 6:32 AM, Alex J. G. Burzynski via RT wrote: >
> > Thu Sep 09 06:32:55 2010: Request 61197 was acted upon. > > Transaction: Ticket created by AJGB > > Queue: Search-Sitemap > > Subject: Search::Sitemap 2.11 on github > > Broken in: 2.10 > > Severity: (no value) > > Owner: Nobody > > Requestors: AJGB@cpan.org > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > > > > > > > Hi, > > > > I've fixed following bugs: > > 60498 Moose changes cause warning about attribute coercion > > 59038 $map->add() doesn't accept a DateTime object for lastmod > > 57260 small documentation bug > > 57240 Search::Sitemap::Index object can't be created > > 57231 minor documentation bug > > 56964 Can't update() a URL's priority > > 52742 read() seems not to read > > > > It's available on http://github.com/ajgb/search-sitemap as version
> 2.11.
> > > > There are separate commits for each bug. > > > > Regards, > > Alex J. G. Burzyński > >
>
Subject: Re: [rt.cpan.org #61197] Search::Sitemap 2.11 on github
Date: Thu, 25 Nov 2010 18:26:40 -0500
To: bug-Search-Sitemap [...] rt.cpan.org
From: Jason Kohles <email [...] jasonkohles.com>
Sorry I've forgotten about this for so long. Could I convince you to fork my existing repo and apply the changes to that, rather than creating a new repo and importing the code? Otherwise it's a lot more work to get the patches applied. Also, for the future, If you apply changes to a fork and then submit a pull request in github, then your changes will end up in my queue and I'm less likely to forget about it. On Oct 31, 2010, at 5:46 PM, Alex J. G. Burzynski via RT wrote: Show quoted text
> Queue: Search-Sitemap > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > > > Hi Jason, > > My offer to help you with maintaining this module still holds. > > Search::Sitemap is a great piece of work and I'm really keen on bringing > it alive again. > > Regards, > Alex > > > On Tue Sep 21 13:31:12 2010, email@jasonkohles.com wrote:
>> Thanks, this is the largest patch anybody has ever sent me for one of >> my modules! Sorry it took so long for me to respond, I've been out of >> town. I'll work on getting a new release out with your fixes ASAP. >> >> Thanks again! >> >> On Sep 9, 2010, at 6:32 AM, Alex J. G. Burzynski via RT wrote: >>
>>> Thu Sep 09 06:32:55 2010: Request 61197 was acted upon. >>> Transaction: Ticket created by AJGB >>> Queue: Search-Sitemap >>> Subject: Search::Sitemap 2.11 on github >>> Broken in: 2.10 >>> Severity: (no value) >>> Owner: Nobody >>> Requestors: AJGB@cpan.org >>> Status: new >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61197 > >>> >>> >>> Hi, >>> >>> I've fixed following bugs: >>> 60498 Moose changes cause warning about attribute coercion >>> 59038 $map->add() doesn't accept a DateTime object for lastmod >>> 57260 small documentation bug >>> 57240 Search::Sitemap::Index object can't be created >>> 57231 minor documentation bug >>> 56964 Can't update() a URL's priority >>> 52742 read() seems not to read >>> >>> It's available on http://github.com/ajgb/search-sitemap as version
>> 2.11.
>>> >>> There are separate commits for each bug. >>> >>> Regards, >>> Alex J. G. Burzyński >>>
>>
> > >
Download (untitled) / with headers
text/plain 376b
I've exported all the changes in AJGB's repo (as of today) and imported them into a fork of your repo, Jason. I've also submitted a pull request on Github (https://github.com/jasonk/search-sitemap/pull/1). AJGB, you might consider forking my repo (https://github.com/madsen/search-sitemap) if you want to make any additional changes, so they'll be easier for Jason to merge.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.