Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 61125
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: rrt [...] sc3d.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.70
Fixed in: (no value)



Subject: Some documentation typos
1. XML::LibXML::Parser: node whose subtree will be the content obtained by parsing the external resource; Although this is level of nesting is visible from the DOM it is transparent to XPath data model, so it is possible to match nodes in an unexpanded entity by the same XPath expression as if the entity was expanded. See also ext_ent_handler. "Although this is level of nesting is" -> "although this nesting is" "was expanded" -> "were expanded" (subjunctive needed here) "labeled labeled" -> "labeled" "XML:LibXML" -> "XML::LibXML" The function "load_html" is incorrectly headed "load_xml". After this function, the indenting goes wrong: all the rest of the parsing functions are indented by one extra level. The indenting should return to the top level at the paragraph starting "The functions described above are implemented to parse well formed documents." 2. XML::LibXML::Element parse_xml_chunk -> parse_balanced_chunk (use the current name, not the old one) 3. XML::LibXML "considered a bad practice" -> "considered bad practice"
From: daniel.frett [...] ccci.org
Download (untitled) / with headers
text/plain 1.2k
attached a patch, the only thing this patch doesn't address is the load_xml => load_html change because it was already applied On Mon Sep 06 17:00:54 2010, rrt wrote: Show quoted text
> 1. XML::LibXML::Parser: > > node whose subtree will be the content obtained by parsing > the external resource; Although this is level of nesting is visible > from the DOM it is transparent to XPath data model, so it is > possible to match nodes in an unexpanded entity by the same XPath > expression as if the entity was expanded. See also > ext_ent_handler. > > "Although this is level of nesting is" -> "although this nesting is" > "was expanded" -> "were expanded" (subjunctive needed here) > > "labeled labeled" -> "labeled" > > "XML:LibXML" -> "XML::LibXML" > > The function "load_html" is incorrectly headed "load_xml". After this > function, the indenting goes wrong: all the rest of the parsing > functions are indented by one extra level. The indenting should return > to the top level at the paragraph starting "The functions described > above are implemented to parse well formed documents." > > 2. XML::LibXML::Element > > parse_xml_chunk -> parse_balanced_chunk (use the current name, not the > old one) > > 3. XML::LibXML > > "considered a bad practice" -> "considered bad practice"
Subject: RT61125.patch
Download RT61125.patch
text/x-diff 3.5k
diff --git a/docs/libxml.dbk b/docs/libxml.dbk index 089844b..f77d7dc 100644 --- a/docs/libxml.dbk +++ b/docs/libxml.dbk @@ -635,7 +635,7 @@ $xml_document = $doc->toString(); # returns a byte string <para>DOM methods also accept binary strings in the original encoding of the document to which the node belongs (UTF-8 is assumed if the node is not attached to any document). Exploiting this feature is NOT RECOMMENDED - since it is considered a bad practice. + since it is considered bad practice. </para> <programlisting><![CDATA[ my $doc = XML::LibXML:Document->new('1.0','iso-8859-2'); @@ -1149,6 +1149,7 @@ $dom = $parser-&gt;load_html(...); </para> </listitem> </varlistentry> + </variablelist> <para>Parsing HTML may cause problems, especially if the ampersand ('&amp;') is used. This is a common @@ -1348,9 +1349,6 @@ $dom = $parser-&gt;load_html(...); </listitem> </varlistentry> </variablelist> - - - </variablelist> </sect2> <sect2> @@ -1593,7 +1591,7 @@ local $XML::LibXML::setTagCompression = 1;</programlisting> IMPORTANT NOTE: This documentation reflects the parser flags available in libxml2 2.7.3. Some options have no effect if an older version of libxml2 is used. </para> - <para>Each of the flags listed below is labeled labeled</para> + <para>Each of the flags listed below is labeled</para> <variablelist> <varlistentry> <term>/parser/</term> @@ -1681,11 +1679,10 @@ local $XML::LibXML::setTagCompression = 1;</programlisting> when substitution of an external entity is disabled, the entity will be represented in the document tree by a XML_ENTITY_REF_NODE node whose subtree will be the content obtained by parsing the external resource; - Although this is level - of nesting is visible from the DOM + Although this nesting is visible from the DOM it is transparent to XPath data model, so it is possible to match nodes in an unexpanded entity by the same XPath expression - as if the entity was expanded. See also ext_ent_handler. + as if the entity were expanded. See also ext_ent_handler. </para> </listitem> </varlistentry> @@ -1848,7 +1845,7 @@ $parser->input_callbacks($c); <listitem> <para>/parser/</para> <para>THIS OPTION IS EXPERIMENTAL!</para> - <para>Although quite powerful, XML:LibXML's DOM implementation is incomplete with respect to + <para>Although quite powerful, XML::LibXML's DOM implementation is incomplete with respect to the DOM level 2 or level 3 specifications. XML::GDOME is based on libxml2 as well and and provides a rather complete DOM implementation by wrapping libgdome. This flag allows you to make @@ -4345,7 +4342,7 @@ $ec14nstring = $node-&gt;toStringEC14N($with_comments, $xpath_expression, $xpath <para><emphasis>Note that appendWellBalancedChunk() is only left for compatibility reasons</emphasis>. Implicitly it uses</para> - <programlisting> my $fragment = $parser-&gt;parse_xml_chunk( $chunk ); + <programlisting> my $fragment = $parser-&gt;parse_balanced_chunk( $chunk ); $node-&gt;appendChild( $fragment );</programlisting> <para>This form is more explicit and makes it easier to control the flow of a script.</para>
Fixed on CPAN by applying Daniel's patch. Thanks for the report.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.