Skip Menu |
 

This queue is for tickets about the Net-DNS-SEC CPAN distribution.

Report information
The Basics
Id: 61104
Status: resolved
Priority: 0/
Queue: Net-DNS-SEC

People
Owner: NLNETLABS [...] cpan.org
Requestors: miek.gieben [...] sidn.nl
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: buglets in Net::DNS::SEC
Date: Mon, 6 Sep 2010 09:43:15 +0200
To: <bug-Net-DNS-SEC [...] rt.cpan.org>
From: Miek Gieben <miek.gieben [...] sidn.nl>
Download (untitled) / with headers
text/plain 1.3k
Hello, The perldoc page of Net::DNS::RR::DS as a typo: create This constructor takes a key object as argument and will return a DS RR object. $dsrr=create Net::DNS::RR::DS($keyrr, ( digtype => "SHA256" ); $keyrr->print; $dsrr->print; there is an extra parens after 'DS($keyrr, (', so: $dsrr=create Net::DNS::RR::DS($keyrr, digtype => "SHA256" ); $keyrr->print; $dsrr->print; is correct. And the following patch extends the key2ds demo prog, so that it actually works and also prints the SHA256 hash. --- Net-DNS-SEC-0.16/demo/key2ds 2010-03-12 14:13:42.000000000 +0100 +++ /home/miekg/key2ds 2010-09-03 14:29:14.000000000 +0200 @@ -1,23 +1,22 @@ #!/usr/bin/perl #$Id: key2ds 169 2004-03-09 14:28:00Z olaf $ - use strict; use Net::DNS; - - # A little util to convert DNSKEY records to DS records # From stdin to stdout # # Author: Miek Gieben, NLnetLabs my $key; - while (<>) { chomp; $key .= $_ }; + while (<>) { $key .= $_ }; my $keyrr = new Net::DNS::RR($key); - my $dsrr = create Net::DNS::RR::DS($keyrr); - print $dsrr->string,"\n"; + my $dssha256 = create Net::DNS::RR::DS($keyrr, digtype => "SHA256"); + my $dssha1 = create Net::DNS::RR::DS($keyrr, digtype => "SHA1"); + print $dssha1->string,"\n"; + print $dssha256->string,"\n"; exit 0; =head1 NAME
Download signature.asc
application/pgp-signature 198b

Message body not shown because it is not plain text.

Applied in trunk. Bedankt! -- Willem


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.