Skip Menu |
 

This queue is for tickets about the Data-AMF CPAN distribution.

Report information
The Basics
Id: 60973
Status: new
Priority: 0/
Queue: Data-AMF

People
Owner: Nobody in particular
Requestors: clamav [...] citromail.hu
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.09
Fixed in: (no value)



Subject: problem in parsing AMF packet
Download (untitled) / with headers
text/plain 460b
I have found two problems in the Packet.pm modul 1. in line 50. $must variable is parsed as u32 but the standard states that the type of must-understand variable is boolean (u8) 2. $message_count is parsed before header type but standard states that packet format is: amf-packet = version header-count *(header-type) message- count *(message-type) I have just attached the modified version of Packet.pm feel free to use it. I hope it will be useful.
Subject: Packet.pm
Download Packet.pm
text/x-perl 4k
package Data::AMF::Packet; use Any::Moose; require bytes; use Data::AMF::Parser; use Data::AMF::Formatter; use Data::AMF::IO; use Data::AMF::Header; use Data::AMF::Message; has version => ( is => 'rw', isa => 'Int', lazy => 1, default => sub { 0 }, ); has headers => ( is => 'rw', isa => 'ArrayRef', lazy => 1, default => sub { [] }, ); has messages => ( is => 'rw', isa => 'ArrayRef', lazy => 1, default => sub { [] }, ); no Any::Moose; sub deserialize { my ($class, $data) = @_; my $io = Data::AMF::IO->new(data => $data); my $ver = $io->read_u16; my $header_count = $io->read_u16; my $parser = Data::AMF::Parser->new(version => 0); my @headers; for my $i (1 .. $header_count) { my $name = $io->read_utf8; my $must = $io->read_u8; my $len = $io->read_u32; my $data = $io->read($len); my ($value) = $parser->parse($data); push @headers, Data::AMF::Header->new( name => $name, must_understand => $must, value => $value, version => $ver, ); } my @messages; my $message_count = $io->read_u16; for my $i (1 .. $message_count) { my $target_uri = $io->read_utf8; my $response_uri = $io->read_utf8; my $len = $io->read_u32; my $data = $io->read($len); my ($value) = $parser->parse($data); push @messages, Data::AMF::Message->new( target_uri => $target_uri, response_uri => $response_uri, value => $value, version => $ver, source => $data ); } return Data::AMF::Packet->new( version => $ver, headers => \@headers, messages => \@messages, ); } sub serialize { my $self = shift; my $io = Data::AMF::IO->new( data => q[] ); $io->write_u16($self->version); $io->write_u16(scalar @{ $self->headers }); $io->write_u16(scalar @{ $self->messages }); for my $header (@{ $self->headers }) { $io->write_utf8( $header->name ); $io->write_u32( $header->must_understand ); my $data; if ($self->version == 3) { my $formatter = Data::AMF::Formatter->new(version => 3)->new; $formatter->io->write_u8(0x11); $formatter->write($header->value); $data = $formatter->io->data; } else { $data = Data::AMF::Formatter->new(version => 0)->format($header->value); } $io->write_u32(bytes::length($data)); $io->write($data); } for my $message (@{ $self->messages }) { $io->write_utf8($message->target_uri); $io->write_utf8($message->response_uri); my $data; if ($self->version == 3) { my $formatter = Data::AMF::Formatter->new(version => 3)->new; $formatter->io->write_u8(0x11); $formatter->write($message->value); $data = $formatter->io->data; } else { $data = Data::AMF::Formatter->new(version => 0)->format($message->value); } $io->write_u32(bytes::length($data)); $io->write($data); } return $io->data; } __PACKAGE__->meta->make_immutable; __END__ =head1 NAME Data::AMF::Packet - serialize / deserialize AMF message packet =head1 SYNOPSIS use Data::AMF::Packet my $packet = Data::AMF::Packet->deserialize($data); my $data = $packet->serialize; =head1 DESCRIPTION Data::AMF::Packet provides to serialize/deserialize AMF Packet. AMF Packet is an extended format of AMF, and is used for Flash's HTTP based Remote Procidure Call (known as Flash Remoting). =head1 SEE ALSO L<Data::AMF>, L<Catalyst::Controller::FlashRemoting> =head1 METHODS =head2 serialize Serialize Data::AMF::Packet object into AMF Packet data. =head2 deserialize($amf_packet) Deserialize AMF Packet, and return Data::AMF::Packet object. =head1 ACCESSORS =head2 version return AMF Packet version. =head2 headers return AMF Packet header objects. (ArrayRef of L<Data::AMF::Header>) =head2 messages return AMF Packet Message objects. (ArrayRef of L<Data::AMF::Message>) =head1 AUTHOR Daisuke Murase <typester@cpan.org> =head1 COPYRIGHT This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of the license can be found in the LICENSE file included with this module. =cut


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.