Skip Menu |
 

This queue is for tickets about the Net-SSH-Perl CPAN distribution.

Report information
The Basics
Id: 60859
Status: resolved
Priority: 0/
Queue: Net-SSH-Perl

People
Owner: Nobody in particular
Requestors: pszmytka [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.34
Fixed in: (no value)



Subject: [patch] $ssh->shell() - terminal height set as width and vice versa
Simple typo, but very annoying. The patch should be self-explanatory. Thanks, szmytson
Subject: perl.net.ssh.patch
Download perl.net.ssh.patch
text/x-diff 986b
--- SSH2.pm 2010-08-29 17:22:22.000000000 +0100 +++ SSH2.pm.orig 2010-08-29 11:57:52.000000000 +0100 @@ -150,8 +150,8 @@ my @sz = Term::ReadKey::GetTerminalSize($ssh->sock); if (defined $sz[0]) { $foundsize = 1; - $packet->put_int32($sz[0]); # height - $packet->put_int32($sz[1]); # width + $packet->put_int32($sz[1]); # height + $packet->put_int32($sz[0]); # width $packet->put_int32($sz[2]); # xpix $packet->put_int32($sz[3]); # ypix } @@ -225,8 +225,8 @@ my @sz = Term::ReadKey::GetTerminalSize($ssh->sock); if (defined $sz[0]) { $foundsize = 1; - $r_packet->put_int32($sz[0]); # height - $r_packet->put_int32($sz[1]); # width + $r_packet->put_int32($sz[1]); # height + $r_packet->put_int32($sz[0]); # width $r_packet->put_int32($sz[2]); # xpix $r_packet->put_int32($sz[3]); # ypix }
From: pszmytka [...] gmail.com
There's the same typo in SSH1.pm as well
Download (untitled) / with headers
text/plain 203b
Hi! Someone already applied the patch, at least it's contained in v1.35. Closing as fixed. Kind regards, Steffen -- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/>


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.