Skip Menu |
 

This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id: 60609
Status: open
Priority: 0/
Queue: Module-Install

People
Owner: Nobody in particular
Requestors: smueller [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: all_from ignores explicitly stated subsets
Download (untitled) / with headers
text/plain 760b
The all_from statement will fetch the information for various things from a main module file. Doing that, it ignores information that was explicitly set otherwise. In my case, I have multiple authors. all_from will only extract the first (and with POD formatting included). Thus I include two lines a la "author 'foo'" in the Makefile.PL. This results in *three* authors. The two manual entries and the auto-detected one. I know that I can manually use many foo_from's and I suspect that for settings which have only one value (i.e. version), the manual setting of it will overwrite the autodetection instead of append to it. But I believe all_from should be smart enough to detect that something was manually overridden and leave it alone. Cheers, Steffen
Subject: Re: [rt.cpan.org #60609] all_from ignores explicitly stated subsets
Date: Sun, 22 Aug 2010 23:15:01 +1000
To: bug-Module-Install [...] rt.cpan.org
From: Adam Kennedy <adamkennedybackup [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
You have to declare them before you run all_from. Did you do so? Adam K On 22 August 2010 18:53, Steffen Mueller via RT <bug-Module-Install@rt.cpan.org> wrote: Show quoted text
> Sun Aug 22 04:53:21 2010: Request 60609 was acted upon. > Transaction: Ticket created by SMUELLER >       Queue: Module-Install >     Subject: all_from ignores explicitly stated subsets >   Broken in: (no value) >    Severity: Wishlist >       Owner: Nobody >  Requestors: smueller@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=60609 > > > > The all_from statement will fetch the information for various things > from a main module file. > > Doing that, it ignores information that was explicitly set otherwise. In > my case, I have multiple authors. all_from will only extract the first > (and with POD formatting included). Thus I include two lines a la > "author 'foo'" in the Makefile.PL. > > This results in *three* authors. The two manual entries and the > auto-detected one. > > I know that I can manually use many foo_from's and I suspect that for > settings which have only one value (i.e. version), the manual setting of > it will overwrite the autodetection instead of append to it. But I > believe all_from should be smart enough to detect that something was > manually overridden and leave it alone. > > Cheers, > Steffen >
Subject: Re: [rt.cpan.org #60609] all_from ignores explicitly stated subsets
Date: Sun, 22 Aug 2010 23:42:38 +0200
To: bug-Module-Install [...] rt.cpan.org
From: Steffen Mueller <smueller [...] cpan.org>
Download (untitled) / with headers
text/plain 384b
Reserved Local Account via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=60609 > > > You have to declare them before you run all_from. > > Did you do so?
Yes. The authors are an "array property". Apparently, all_from will just append whatever (single) author it parses from the POD instead of, well, skipping the properties that were already set. Cheers, Steffen


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.