Skip Menu |
 

This queue is for tickets about the Google-Chart CPAN distribution.

Report information
The Basics
Id: 60521
Status: new
Priority: 0/
Queue: Google-Chart

People
Owner: Nobody in particular
Requestors: chad.a.davis [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.09000_03
Fixed in: (no value)



Subject: Patch against 0.09000_03 for method conflict: type()
Download (untitled) / with headers
text/plain 460b
Running tests on Google::Chart 0.09000_03 I get t/rt42260.t .. You are overwriting a locally defined function (type) with an accessor I traced this to a conflict between: Google::Chart::WithMarker::type() and Moose::Util::TypeConstraints::type() I thought to resolve this by renaming WM::type to WM::markertype (attached patch). All tests pass for me now. Moose 1.09 perl, v5.10.0 built for i386-linux-thread-multi Fedora release 11 (Leonidas) - Chad
Subject: WithMarker.pm.patch
Download WithMarker.pm.patch
text/x-diff 645b
--- lib/Google/Chart/WithMarker.pm.bak 2010-08-19 15:42:32.235295225 +0200 +++ lib/Google/Chart/WithMarker.pm 2010-08-19 15:42:59.038300960 +0200 @@ -27,7 +27,7 @@ my $markers = $dataset->markers; foreach my $marker (@$markers) { push @chm, join(',', - $marker->type, + $marker->markertype, $marker->color || '', $i, !defined $marker->point ? -1 : $marker->point, @@ -87,7 +87,7 @@ } ; -has type => ( +has markertype => ( is => 'ro', isa => 'Google::Chart::DataSet::MarkerType', );
From: chad.a.davis [...] gmail.com
PS. This applies to 0.09000_04 as well. The same patch also fixes 0.09000_04.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.