Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the IO-Tty CPAN distribution.

Report information
The Basics
Id:
60014
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
TODDR [...] cpan.org
Requestors:
CHORNY [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Wishlist
Broken in:
1.08
Fixed in:
1.08_02



Subject: better META.yml
repository and license in META.yml -- Alexandr Ciornii, http://chorny.net
Subject: Makefile.PL.patch
--- Makefile.PL.bak 2010-08-03 03:36:57.475875000 +0300 +++ Makefile.PL 2010-08-03 03:14:47.897750000 +0300 @@ -399,7 +399,7 @@ print "DEFINE = @{[sort keys %define]}\n"; -WriteMakefile( +WriteMakefile1( 'NAME' => 'IO::Tty', 'VERSION' => $Package_Version, 'DEFINE' => join(" ", sort keys %define), @@ -407,10 +407,14 @@ 'clean' => {'FILES' => 'xssubs.c conf Tty.exp_old log'}, 'realclean' => {'FILES' => 'Tty IO-Tty.ppd'}, 'MAP_TARGET' => 'perltty', - ($] >= 5.00503) ? - ( AUTHOR => 'Roland Giersig <RGiersig@cpan.org>', - ABSTRACT => 'Pseudo ttys and constants' ) : - (), + 'AUTHOR' => 'Roland Giersig <RGiersig@cpan.org>', + 'ABSTRACT' => 'Pseudo ttys and constants', + 'LICENSE' => 'perl', + 'META_MERGE' => { + 'resources' => { + 'repository' => 'https://expectperl.svn.sourceforge.net/svnroot/expectperl/IO-Tty/trunk', + }, + }, ); sub MY::postamble { @@ -424,3 +428,27 @@ ESQ } + +sub WriteMakefile1 { #Written by Alexandr Ciornii, version 0.21. Added by eumm-upgrade. + my %params=@_; + my $eumm_version=$ExtUtils::MakeMaker::VERSION; + $eumm_version=eval $eumm_version; + die "EXTRA_META is deprecated" if exists $params{EXTRA_META}; + die "License not specified" if not exists $params{LICENSE}; + if ($params{BUILD_REQUIRES} and $eumm_version < 6.5503) { + #EUMM 6.5502 has problems with BUILD_REQUIRES + $params{PREREQ_PM}={ %{$params{PREREQ_PM} || {}} , %{$params{BUILD_REQUIRES}} }; + delete $params{BUILD_REQUIRES}; + } + delete $params{CONFIGURE_REQUIRES} if $eumm_version < 6.52; + delete $params{MIN_PERL_VERSION} if $eumm_version < 6.48; + delete $params{META_MERGE} if $eumm_version < 6.46; + delete $params{META_ADD} if $eumm_version < 6.46; + delete $params{LICENSE} if $eumm_version < 6.31; + delete $params{AUTHOR} if $] < 5.005; + delete $params{ABSTRACT_FROM} if $] < 5.005; + delete $params{BINARY_LOCATION} if $] < 5.005; + + WriteMakefile(%params); +} +
Thanks, will add in the next release. Roland -- RGiersig@cpan.org
On Fri Sep 10 01:39:30 2010, TODDR wrote:
Show quoted text
> Fixed by commit in github. Please review if you can. > > http://github.com/toddr/IO- > Tty/commit/0af94687f7def1a1676f479903d3722a69ccbec8
All seems ok. I'd also suggest to use VERSION_FROM. That will require losing compatibility with EU::MM in perls before 5.4, but I don't think anybody cares. -- Alexandr Ciornii, http://chorny.net
Fixed in 1.08_02. Will be in 1.09 later this week


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.