Skip Menu |
 

This queue is for tickets about the IO-Compress CPAN distribution.

Report information
The Basics
Id: 59506
Status: open
Priority: 0/
Queue: IO-Compress

People
Owner: Nobody in particular
Requestors: dmuey [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: trimming down imports/exports would gain speed and save memory
Download (untitled) / with headers
text/plain 466b
Hello, Thanks for your hard work on this excellent module! My boss was doing some profiling and noticed that there was a lot of unnecessary importing w/ IO::Compress. Here is a list: http://koston.org/iocompress_symbol_imports.txt We've been trimming our code down by changing this sort of thing: use XYZ; foo(); to use XYZ (); XYZ::foo(); and wanted to request the same w/ IO::Compress. Would you be willing to look over a patch? Thanks! -- Dan Muey
Download (untitled) / with headers
text/plain 620b
Hi Dan, In principle I don't have a problem with what you suggest, but I'd like to have a feel for what it saves in both time & memory. The fully qualified names for variables & subs can get quite long. Rather than disabling all importing or symbols, have you looked into only importing those that are actually used? Also, one other thing to consider - my compression modules build with all versions of Perl from 5.004 onwards. Any patch must take that into account. Don't worry if you don't have a full suite of Perl binaries - I have a setup that allows me to test my modules against all Perl versions. cheers Paul
Subject: Re: [rt.cpan.org #59506] trimming down imports/exports would gain speed and save memory
Date: Sun, 18 Jul 2010 16:47:10 -0500
To: bug-IO-Compress [...] rt.cpan.org
From: Dan Muey <webmaster [...] simplemood.com>
Download (untitled) / with headers
text/plain 843b
Thank you Paul, I'll gather some specifics and post details Monday. On Jul 18, 2010, at 4:41 PM, Paul Marquess via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=59506 > > > Hi Dan, > > In principle I don't have a problem with what you suggest, but I'd like > to have a feel for what it saves in both time & memory. The fully > qualified names for variables & subs can get quite long. > > Rather than disabling all importing or symbols, have you looked into > only importing those that are actually used? > > Also, one other thing to consider - my compression modules build with > all versions of Perl from 5.004 onwards. Any patch must take that into > account. Don't worry if you don't have a full suite of Perl binaries - I > have a setup that allows me to test my modules against all Perl versions. > > cheers > Paul
Download (untitled) / with headers
text/plain 328b
The attached report is regarding the symbols ( generated from this script http://drmuey.com/? do=page&id=102 ) Summary is: Files : 27 Imports: 88 Symbols: 579 For memory and time we've found an average of .25MB memory saving w/ the IO package. We'll work on a patch of IO::Compress for easy comparison soon, thanks!
Subject: IO-Compress-2.030.txt

Message body is not shown because it is too large.

Thanks Daniel


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.