Skip Menu |
 

This queue is for tickets about the Moose CPAN distribution.

Report information
The Basics
Id: 59478
Status: stalled
Priority: 0/
Queue: Moose

People
Owner: Nobody in particular
Requestors: gregoa [...] debian.org
Cc: ANSGAR [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
0001-Work-around-unexpected-float-conversion-in-overloade.patch
signature.asc



Subject: Build problems on ia64
Date: Sat, 17 Jul 2010 16:23:10 +0200
To: bug-Moose [...] rt.cpan.org
From: gregor herrmann <gregoa [...] debian.org>
Download (untitled) / with headers
text/plain 663b
Hi, Moose' tests failed on Debian's ia64 build daemon: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588118 https://buildd.debian.org/fetch.cgi?pkg=libmoose-perl&arch=ia64&ver=1.08-1&stamp=1276806453&file=log&as=raw (all logs: https://buildd.debian.org/status/package.php?p=libmoose-perl ) Maybe someone of the Moose folks has any idea what's going on there? Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `- BOFH excuse #284: Electrons on a bender
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

From: ntyni [...] iki.fi
Download (untitled) / with headers
text/plain 731b
On Sat Jul 17 10:23:20 2010, gregoa@debian.org wrote: Show quoted text
> Hi, > > Moose' tests failed on Debian's ia64 build daemon: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588118 > https://buildd.debian.org/fetch.cgi?pkg=libmoose- > perl&arch=ia64&ver=1.08-1&stamp=1276806453&file=log&as=raw > (all logs: https://buildd.debian.org/status/package.php?p=libmoose- > perl ) > > Maybe someone of the Moose folks has any idea what's going on there?
It's an unexpected integer to float conversion in the numeric comparison, visible on ia64 because refaddr() returns big integers there. Proposed workaround attached. I'm going to file a Perl bug about this although I suspect it may be considered a feature. -- Niko Tyni ntyni@debian.org
Subject: 0001-Work-around-unexpected-float-conversion-in-overloade.patch
From 1be1c887ecce33250e187516bb37d013b71b0e4c Mon Sep 17 00:00:00 2001 From: Niko Tyni <ntyni@debian.org> Date: Fri, 20 Aug 2010 13:32:31 -0600 Subject: [PATCH] Work around unexpected float conversion in overloaded numeric comparison As seen in <http://bugs.debian.org/588118>, the numeric comparison will trigger an unexpected integer to float conversion behind the scenes. This may lose precision and cause test failures on systems where refaddr() returns big integers like ia64 ("Itanium"). Explicitly numifying before comparing seems to work around this. --- lib/Moose/Meta/TypeConstraint.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Moose/Meta/TypeConstraint.pm b/lib/Moose/Meta/TypeConstraint.pm index 1c8f3de..700f77f 100644 --- a/lib/Moose/Meta/TypeConstraint.pm +++ b/lib/Moose/Meta/TypeConstraint.pm @@ -135,7 +135,7 @@ sub equals { my $other = Moose::Util::TypeConstraints::find_type_constraint($type_or_name) or return; - return 1 if $self == $other; + return 1 if (0+$self == 0+$other); if ( $self->has_hand_optimized_type_constraint and $other->has_hand_optimized_type_constraint ) { return 1 if $self->hand_optimized_type_constraint == $other->hand_optimized_type_constraint; -- 1.7.1
From: ntyni [...] iki.fi
Download (untitled) / with headers
text/plain 918b
On Thu Aug 26 15:23:12 2010, ntyni@iki.fi wrote: Show quoted text
> On Sat Jul 17 10:23:20 2010, gregoa@debian.org wrote:
> > Hi, > > > > Moose' tests failed on Debian's ia64 build daemon: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588118 > > https://buildd.debian.org/fetch.cgi?pkg=libmoose- > > perl&arch=ia64&ver=1.08-1&stamp=1276806453&file=log&as=raw > > (all logs: https://buildd.debian.org/status/package.php?p=libmoose- > > perl ) > > > > Maybe someone of the Moose folks has any idea what's going on there?
> > It's an unexpected integer to float conversion in the numeric > comparison, visible on ia64 because refaddr() returns big integers there. > > Proposed workaround attached. I'm going to file a Perl bug about this > although I suspect it may be considered a feature.
FYI, it's now [perl #77456] http://rt.perl.org/rt3/Ticket/Display.html?id=77456 Thanks for your work, -- Niko Tyni ntyni@debian.org
On Thu Aug 26 15:38:58 2010, ntyni@iki.fi wrote: Show quoted text
> On Thu Aug 26 15:23:12 2010, ntyni@iki.fi wrote:
> > On Sat Jul 17 10:23:20 2010, gregoa@debian.org wrote:
> > > Hi, > > > > > > Moose' tests failed on Debian's ia64 build daemon: > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588118 > > > https://buildd.debian.org/fetch.cgi?pkg=libmoose- > > > perl&arch=ia64&ver=1.08-1&stamp=1276806453&file=log&as=raw > > > (all logs: https://buildd.debian.org/status/package.php?p=libmoose- > > > perl ) > > > > > > Maybe someone of the Moose folks has any idea what's going on there?
> > > > It's an unexpected integer to float conversion in the numeric > > comparison, visible on ia64 because refaddr() returns big integers there. > > > > Proposed workaround attached. I'm going to file a Perl bug about this > > although I suspect it may be considered a feature.
> > FYI, it's now [perl #77456] > > http://rt.perl.org/rt3/Ticket/Display.html?id=77456 > > Thanks for your work,
Is this still an issue? I'm gonna mark this stalled until we have a resolution path. -Chris


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.