Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Mouse CPAN distribution.

Report information
The Basics
Id: 59460
Status: resolved
Priority: 0/
Queue: Mouse

People
Owner: Nobody in particular
Requestors: csjewell [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.62
Fixed in: (no value)



Subject: Test::Requires is not a required prerequisite unless release-testing...
Download (untitled) / with headers
text/plain 3.5k
Found this out during building of Strawberry Perl Professional: (output to stdout abbreviated below, attached as debug.out. stderr output attached as debug.err. Yes, the ARRAY(0x397fbc4), ARRAY(0x397fa64) thing is a bug in CPAN.) Loading CPAN... Installing Mouse from CPAN... Going to read '\\tsclient\C\minicpan\authors\01mailrc.txt.gz' ............................................................................DONE Going to read '\\tsclient\C\minicpan\modules\02packages.details.txt.gz' Database was generated on Sat, 10 Jul 2010 18:26:59 GMT ............................................................................DONE Going to read '\\tsclient\C\minicpan\modules\03modlist.data.gz' ............................................................................DONE $ENV{PATH} = 'C:\strawberry\c\bin;C:\strawberry\perl\site\bin;C:\strawberry\perl\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\Program Files\SlikSvn\bin\;C:\Program Files\Git\cmd;C:\Program Files\TortoiseSVN\bin;C:\buildsb\perl\site\bin' Running install for module 'Mouse' Running make for G/GF/GFUJI/Mouse-0.62.tar.gz Checksum for \\tsclient\C\minicpan\authors\id\G\GF\GFUJI\Mouse-0.62.tar.gz ok CPAN.pm: Going to build G/GF/GFUJI/Mouse-0.62.tar.gz Generate Mouse::Tiny ... done. Mouse configured with XS. NOTE: You can try --pp option to configure Mouse with Pure Perl. Writing ppport.h Checking if your kit is complete... Looks good Writing Makefile for Mouse Show quoted text
---- Unsatisfied dependencies detected during ---- ---- GFUJI/Mouse-0.62.tar.gz ---- Test::Requires [requires] Ignoring dependencies on modules ARRAY(0x397fbc4), ARRAY(0x397fa64) cp lib/Mouse/Tiny.pod blib\lib\Mouse\Tiny.pod cp lib/Mouse/TypeRegistry.pm blib\lib\Mouse\TypeRegistry.pm ... C:\strawberry\perl\bin\perl.exe "-Iinc" -MExtUtils::Command -e "chmod" -- 755 blib\arch\auto\Mouse\Mouse.dll C:\strawberry\perl\bin\perl.exe "-Iinc" -MExtUtils::Command -e "cp" -- Mouse.bs blib\arch\auto\Mouse\Mouse.bs C:\strawberry\perl\bin\perl.exe "-Iinc" -MExtUtils::Command -e "chmod" -- 644 blib\arch\auto\Mouse\Mouse.bs GFUJI/Mouse-0.62.tar.gz C:\strawberry\c\bin\dmake.EXE -- OK Running make test C:\strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib\lib', 'blib\arch')" t/*.t t/*/*.t t/000-load.t ................................................... ok t/000_recipes/002_schwartz_tutorial.t .......................... ok ... t/800_with_external/002-externals.t ............................ skipped: for release testing ... All tests successful. Test Summary Report ------------------- t/000_recipes/moose_cookbook_roles_recipe1.t (Wstat: 0 Tests: 63 Failed: 0) TODO passed: 5 t/030_roles/001_meta_role.t (Wstat: 0 Tests: 26 Failed: 0) TODO passed: 13 t/030_roles/042_compose_overloading.t (Wstat: 0 Tests: 1 Failed: 0) TODO passed: 1 t/100_bugs/025_universal_methods_wrappable.t (Wstat: 0 Tests: 2 Failed: 0) TODO passed: 1-2 Files=234, Tests=5025, 31 wallclock secs ( 1.66 usr + 0.47 sys = 2.13 CPU) Result: PASS GFUJI/Mouse-0.62.tar.gz Tests succeeded but one dependency not OK (Test::Requires) GFUJI/Mouse-0.62.tar.gz [dependencies] -- NA Running make install make test had returned bad status, won't install without force Completed install of Mouse [The reason I find this is that during Strawberry Perl-ish installing, I tell CPAN not to follow prereqs, so I can keep track of all modules installed by hand-coding the order.] I'll attach a patch made with git format-patch that fixes this problem within the next few hours, if you'd like.
Subject: debug.out
Download debug.out
application/octet-stream 25.1k

Message body not shown because it is not plain text.

Subject: debug.err
Download debug.err
application/octet-stream 9k

Message body not shown because it is not plain text.

Subject: [PATCH] Test::Requires is not a required prerequisite unless release-testing...
Attaching patch, as promised.
Subject: 0001-Wrap-the-requirement-for-Test-Requires-in-ENV-RELEAS.patch
From 00a0558d0fce633a9fe79c2612e961128c73fba7 Mon Sep 17 00:00:00 2001 From: Curtis Jewell <perl@csjewell.fastmail.us> Date: Fri, 16 Jul 2010 14:05:08 -0600 Subject: [PATCH] Wrap the requirement for Test::Requires in $ENV{RELEASE_TESTING}. This fixes RT#59460. --- Makefile.PL | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 17cdb7e..dff623f 100755 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,7 +1,7 @@ # for developpers: BEGIN{ if(grep{ $_ eq '--author' } @ARGV){ - print "^X -S cpanm < author/requires.cpanm\n"; + print "$^X -S cpanm < author/requires.cpanm\n"; system "$^X -S cpanm < author/requires.cpanm"; } } @@ -26,7 +26,9 @@ requires 'Scalar::Util' => 1.14; test_requires 'Test::More' => 0.88; test_requires 'Test::Exception' => 0.29; -test_requires 'Test::Requires' => 0.03; +if ( $ENV{RELEASE_TESTING} || (grep { $_ eq '--author' } @ARGV) ) { + test_requires 'Test::Requires' => 0.03; +} # test_requires 'Test::Output' => 0.16; # too many dependencies! if($] < 5.010) { -- 1.6.5.1.1367.gcd48
Download (untitled) / with headers
text/plain 278b
Hello, Thanks! You are right. The patch has been applied. I didn't know that only authors require Test::Requires :) cf. http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo/Mouse.git;a=commitdiff;h=01f38ab1a660b3497e02d8f737b82dbe02299f66 -- Goro Fuji (gfx) GFUJI at CPAN.org


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.