Skip Menu |
 

This queue is for tickets about the XML-SAX-RTF CPAN distribution.

Report information
The Basics
Id: 5943
Status: resolved
Priority: 0/
Queue: XML-SAX-RTF

People
Owner: Nobody in particular
Requestors: grantm [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: XML::SAX::RTF should not register as an XML parser
Download (untitled) / with headers
text/plain 1.1k
The Makefile.PL script in the XML-SAX-RTF-0.1 distribution includes a call to XML::SAX->add_parser which registers XML::SAX::RTF in ParserDetails.ini. This is a problem because the last module registered in ParserDetails.ini becomes the default SAX parser for XML. If the module cannot parse XML then any attempt to parse XML using SAX from that point on will fail. Some example failures caused by XML::SAX::RTF being the default parser: http://www.nntp.perl.org/group/perl.cpan.testers/131181 http://www.nntp.perl.org/group/perl.cpan.testers/120169 http://www.nntp.perl.org/group/perl.cpan.testers/76917 An example of another module which generates SAX events from a non-XML source (and does not register in ParserDetails.ini): http://search.cpan.org/src/MSERGEANT/XML-Generator-DBI-1.00/Makefile.PL I've attached a patch which simply removes the relevant section of Makefile.PL. I haven't actually used XML::SAX::RTF myself, but I suspect the POD also needs an update to reflect that the new() method should be called directly to create an RTF parser object rather than using XML::SAX::ParserFactory. Regards Grant
Download no_reg.patch
text/x-diff 500b
--- Makefile.PL-orig Tue Apr 6 21:20:30 2004 +++ Makefile.PL Tue Apr 6 21:20:30 2004 @@ -6,15 +6,3 @@ 'PREREQ_PM' => { 'XML::SAX' => 0 } # require XML::SAX ); - -sub MY::install { - package MY; - my $script = shift->SUPER::install(@_); - $script =~ s/install :: (.*)$/install :: $1 install_sax_driver/m; - $script .= <<"INSTALL"; -install_sax_driver : -\t\@\$(PERL) -MXML::SAX -e 'XML::SAX->add_parser(q(\$(NAME)))->save_parsers();' - -INSTALL - return $script; -}
RT-Send-CC: srezic [...] cpan.org
Download (untitled) / with headers
text/plain 336b
This bug seems to be a serious one because it affects how other modules break. Even if it is very old and got little attention, we should get rid of it on CPAN. @ERIKRAY: Do you have an opinion on this? @GRANTM: would you be willing to take over the module? Eventually only to apply the patch and deprecate the whole module? Thanks,
Subject: Re: [rt.cpan.org #5943] XML::SAX::RTF should not register as an XML parser
Date: Mon, 05 May 2008 08:56:41 +1200
To: bug-XML-SAX-RTF [...] rt.cpan.org
From: Grant McLean <grant [...] mclean.net.nz>
Download (untitled) / with headers
text/plain 675b
On Sun, 2008-05-04 at 14:40 -0400, Andreas Koenig via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=5943 > > > This bug seems to be a serious one because it affects how other modules > break. Even if it is very old and got little attention, we should get > rid of it on CPAN. > > @ERIKRAY: Do you have an opinion on this? > > @GRANTM: would you be willing to take over the module? Eventually only > to apply the patch and deprecate the whole module?
Sure. I'm not sure that it needs to be deprecated necessarily. And it would be nice if we could find a maintainer. But in the meantime I'd be prepared to take it over to get the patch out. Cheers Grant
Download (untitled) / with headers
text/plain 430b
Thank you, Grant, for volunteering! We've waited now for four years and now again for two weeks for an answer. I think the time is good for giving you a co-maintainer bit on PAUSE. You are now able to upload a new version. Please make a note in a prominent place in the distro that links to this RT ticket so that when Erik comes back he does not have to dig too deep to find out how we came to this solution. Thank you again,
Download (untitled) / with headers
text/plain 724b
On Sun May 18 11:09:36 2008, ANDK wrote: Show quoted text
> Thank you, Grant, for volunteering! > > We've waited now for four years and now again for two weeks for an > answer. I think the time is good for giving you a co-maintainer bit on > PAUSE. You are now able to upload a new version. > > Please make a note in a prominent place in the distro that links to this > RT ticket so that when Erik comes back he does not have to dig too deep > to find out how we came to this solution. > > Thank you again,
Don't suppose we've seen any movement on this? I'm seeing this popping up as an issue in CPAN Tester and in our local bug queue: http://www.cpantesters.org/cpan/report/5516178 http://bugzilla.open-bio.org/show_bug.cgi?id=2975
Version 0.2 of this module (released yesterday) includes the patch to fix this problem.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.