Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 58953
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: jjore [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: perlcritic shebang created incorrectly
Download (untitled) / with headers
text/plain 698b
I used perl-5.10.0 at /home/jjore/perl5/perlbrew/perls/perlcritic/bin/perl to build Perl-Critic-1.108 and it created the script /home/jjore/perl5/perlbrew/perls/perlcritic/bin/perlcritic with the wrong shebang. It appears that ./Build looked in $PATH instead of using $^X. Got: GOT: #!/rhel5pdi/home/jjore/perl5/perlbrew/perls/padre/bin/perl eval 'exec /rhel5pdi/home/jjore/perl5/perlbrew/perls/padre/bin/perl -S $0 ${1+"$@"}' if 0; # not running under some shell EXPECTED: #!/rhel5pdi/home/jjore/perl5/perlbrew/perls/perlcritic/bin/perl eval 'exec /rhel5pdi/home/jjore/perl5/perlbrew/perls/perlcritic/bin/perl -S $0 ${1+"$@"}' if 0; # not running under some shell
Subject: Re: [rt.cpan.org #58953] perlcritic shebang created incorrectly
Date: Tue, 29 Jun 2010 15:57:53 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Download (untitled) / with headers
text/plain 267b
Are you sure about the perl path used to build P::C? Having "padre" in the "GOT" path makes me suspicious. As I understand it, everything under Padre does gets forced into Padre's perl; you can't use multiple perl versions with Padre. ('course, I could be wrong.)
Subject: Re: [rt.cpan.org #58953] perlcritic shebang created incorrectly
Date: Tue, 29 Jun 2010 16:09:55 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Download (untitled) / with headers
text/plain 133b
And besides that, P::C doesn't do anything directly with shebangs. It's your Module::Build that's busted if it isn't Padre's fault.
CC: jjore [...] cpan.org
Subject: Re: [rt.cpan.org #58953] perlcritic shebang created incorrectly
Date: Tue, 29 Jun 2010 23:21:10 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Joshua ben Jore <twists [...] gmail.com>
Download (untitled) / with headers
text/plain 811b
On Tue, Jun 29, 2010 at 1:58 PM, Elliot Shank via RT <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=58953 > > > Are you sure about the perl path used to build P::C?  Having "padre" in the "GOT" path makes me suspicious.  As I understand it, everything under Padre does gets forced into Padre's perl; you can't use multiple perl versions with Padre.  ('course, I could be wrong.)
The 'padre' in the path is a red herring. It's just a perl that's had Padre installed into it and I intended the perl for running *only* padre. Thanks for the note about Module::Build. I can only assume M::B is wrong then. :-/ My original symptoms were that my newly installed perlcritic script was unable to load the Perl::Critic because the perl running it has no Perl::Critic. Josh


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.