Skip Menu |
 

This queue is for tickets about the Tie-DBI CPAN distribution.

Report information
The Basics
Id: 58813
Status: patched
Priority: 0/
Queue: Tie-DBI

People
Owner: Nobody in particular
Requestors: REHSACK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.05
Fixed in: (no value)



Subject: Several Tie::DBI issues - with patch
Download (untitled) / with headers
text/plain 1.9k
Hi Todd, hi Lincoln, at first I want to express my acknowledgment and thank for your great work at Tie::DBI. I'm unsure who is the primary maintainer now (does Todd just apply some work, but main development is still at Lincoln or has Todd took over the maintainership), so I address both. While I take a short time out from updating DBD::AnyData to the current DBD::File requirements, I start some work on Template::DBI which supports Tie::DBI, too (just for the history of my suggestions). I detected some errors in the Tie::DBI tests - and so I investigated some time. At first I've seen, your tests didn't realize that DBI ships a DBD which is for most tests fully usable: DBD::DBM. So I updated t/DBI.t (patch-aa) to allow DBI_DSN (DBI_USER, DBI_PASS) environment variables can be used, too (and remove a "Useless localization of scalar assignment at t/DBI.t line 130." warning). Then I updated lib/Tie/DBI.pm (patch-ab) to support DBD::DBM (and all other DBD::File based DBD's a bit better).: bind and bindselect is fully supported by DBD::File (and derived drivers), so I added all I know. LISTFIELDS is not an ANSI SQL command (neither my PostgreSQL reference book nor my SQL Bible name that command), - I added DBD::File derived drivers to the list of DBD's which do not support them. I suggest to convert this list into a CAN_LISTFIELDS (is expected to be shorted and will simplify logical expressions evaluating it). Tie::DBI::STORE has a minor logical issue: eval { local $dbh->{PrintError} = 0; ... }; will return the result of $dbh->STORE( "PrintError", $origValue ); at the end of the eval block. Fixed that. _run_query need to $dbh->quote() when not $self->{CanBindSelect} (Tie::DBI::_quote seems not to work - I didn't investigate why). That's all and it runs fine now \o/ I would be glad if you join us at dbi-dev@perl.org to keep up-to-date on DBI and DBD development. Further you're welcome to join daily debates at irc://irc.perl.org/dbi Best regards, Jens
Subject: patch-ab
Download patch-ab
application/octet-stream 2.5k

Message body not shown because it is not plain text.

Subject: patch-aa
Download patch-aa
application/octet-stream 1.8k

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 138b
I've put your patches into the next release on github: https://github.com/toddr/Tie-DBI/commit/98db24f0a608033c287f054a7e5036df49574946
Download (untitled) / with headers
text/plain 138b
I've put your patches into the next release on github: https://github.com/toddr/Tie-DBI/commit/98db24f0a608033c287f054a7e5036df49574946


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.