This queue is for tickets about the Net-OpenID-Consumer CPAN distribution.

Report information
The Basics
Id:
58368
Status:
resolved
Priority:
Low/Low

People
Owner:
crew [...] cs.stanford.edu
Requestors:
james [...] mastros.biz
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
  • 1.030099_006
  • 1.11



Subject: Incorrect error message when passing unknown handlers to handle_server_response
Date: Mon, 14 Jun 2010 10:49:31 +0100
To: bug-Net-OpenID-Consumer@rt.cpan.org
From: James Mastros <james@mastros.biz>
Passing an unknown callback to handle_server_response will result in the exception "Unknown callbacks setup_required,error,not_openid,verified,cancelled" ... which doesn't actually give the name of the unsupported callback, but rather of the supported ones. Line 362 of Consumer.pm should be "Carp::croak("Unknown callbacks ".join(',', keys %callbacks_in)) if %callbacks_in;" instead of "Carp::croak("Unknown callbacks ".join(',', keys %callbacks)) if %callbacks_in;", I think. (Untested thus far.) Thank you, -=- James Mastros
yes, that's the right fix. applied, thanks.
I believe this is fixed in Net-OpenID-Consumer-1.11 If you want to try it out, please make sure you've also installed the latest Net-OpenID-Common. Feel free to re-open (or start a new ticket) if I'm mistaken about this. Thanks for the report and sorry this took so long to get to... - Roger Crew (new co-maintainer as of a few weeks ago)


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.