Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 57898
Status: resolved
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: MITHALDU [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3.101461
Fixed in: (no value)



Subject: gatherdir doesn't handle windows paths well, breaks tests and manifest
Download (untitled) / with headers
text/plain 786b
Here is a patch for this: http://github.com/wchristian/dist-zilla/ commit/d8c12e00f9e01471c6f1129dfe46ecbda3800b59 And the rationale: Ahead: All of the following assumes Win32 as the platform where these things were observed on. The file names DZP::GD gathers were originally in platform-native format, this however meant two things: 1. the tests for the module failed because they expect unix-style paths 2. the MANIFEST was broken because it was written with the wrong windows style paths, including escaping and all A better fix would probably be to write the test so it checks for platform-native paths and to make the MAKEFILE-writer convert to unix style when it writes. However, that is wasted effort in my opinion, since Windows understands unix-style paths just fine.
I believe this has been fixed. -- rjbs


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.