Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 57841
Status: open
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Check for duplicate tarball name before uploading
Download (untitled) / with headers
text/plain 218b
It would be good to check for a duplicate tarball before uploading to CPAN. (Either in DZ or as a feature in CPAN::Uploader). This would be most useful to catch duplicate uploads on the same day with auto-versioning.
Download (untitled) / with headers
text/plain 485b
On 2010-05-25 23:35:01, DAGOLDEN wrote: Show quoted text
> It would be good to check for a duplicate tarball before uploading to > CPAN. (Either in DZ or as a feature in CPAN::Uploader). This would be > most useful to catch duplicate uploads on the same day with auto-versioning.
I'm not opposed, but I'm not sure where we want to look. We'd want to check "incoming" as well as figure out if there's already a file with that name, indexed, under anybody's author dir. Seems non-trivial. -- rjbs
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
Date: Wed, 9 Jun 2010 09:44:06 -0400
To: bug-Dist-Zilla [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 1.1k
On Wed, Jun 9, 2010 at 7:56 AM, Ricardo Signes via RT <bug-Dist-Zilla@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=57841 > > > On 2010-05-25 23:35:01, DAGOLDEN wrote:
>> It would be good to check for a duplicate tarball before uploading to >> CPAN.  (Either in DZ or as a feature in CPAN::Uploader).  This would be >> most useful to catch duplicate uploads on the same day with auto-versioning.
> > I'm not opposed, but I'm not sure where we want to look.  We'd want to check "incoming" as well > as figure out if there's already a file with that name, indexed, under anybody's author dir.
I was thinking it could be more along the lines of checking for the tarball under the author's directory. e.g. If I'm DAGOLDEN and uploading Foo-Bar-1.23.tar.gz, to just do a HEAD check on http://$cpan_mirror/authors/id/D/DA/DAGOLDEN/Foo-Bar-1.23.tar.gz. If the CPAN mirror is a "fast" one, then as long as authors aren't uploading more than once per minute, the check would work reasonably well. Checking incoming is probably more than is necessary. And nothing will help for duplicates that were deleted but are in the PAUSE database and would be rejected. -- David
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
Date: Wed, 9 Jun 2010 10:14:18 -0400
To: David Golden via RT <bug-Dist-Zilla [...] rt.cpan.org>
From: Ricardo Signes <rjbs [...] cpan.org>
Download (untitled) / with headers
text/plain 523b
* David Golden via RT <bug-Dist-Zilla@rt.cpan.org> [2010-06-09T09:44:46] Show quoted text
> Checking incoming is probably more than is necessary. And nothing > will help for duplicates that were deleted but are in the PAUSE > database and would be rejected.
Actually, incoming is where I've heard about this problem most often, from people who have accidentally added UploadToCPAN twice. Of course, this is pretty crazy and the current behavior (throw an error when the second upload is attempted) is probably okay. So, okay. -- rjbs
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
Date: Wed, 9 Jun 2010 10:19:14 -0400
To: bug-Dist-Zilla [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 807b
On Wed, Jun 9, 2010 at 10:14 AM, Ricardo Signes via RT <bug-Dist-Zilla@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=57841 > > > * David Golden via RT <bug-Dist-Zilla@rt.cpan.org> [2010-06-09T09:44:46]
>> Checking incoming is probably more than is necessary.  And nothing >> will help for duplicates that were deleted but are in the PAUSE >> database and would be rejected.
> > Actually, incoming is where I've heard about this problem most often, from > people who have accidentally added UploadToCPAN twice.  Of course, this is > pretty crazy and the current behavior (throw an error when the second upload is > attempted) is probably okay.  So, okay.
For me, it's more likely to be forgetting N=1 with an auto-version, particularly with the TZ difference factored in. David
Download (untitled) / with headers
text/plain 238b
I'll just mention that my ArchiveRelease plugin provides a partial solution to this. It'll only catch duplicate releases made on the same machine (or at least from machines that archive to the same network share), but it might help you.
Download (untitled) / with headers
text/plain 332b
Right now, if I upload a duplicate tarball, UploadToCPAN fails because PAUSE says "no, that's a dupe," and it gives an error response. What does this gain over that? Also, what if we just got that error message and instead of dying "509 BAD QUERY" (or whatever) we turned it into "there's already a duplicate, aborting." -- rjbs
Download (untitled) / with headers
text/plain 529b
On Thu Jul 25 16:07:09 2013, RJBS wrote: Show quoted text
> Right now, if I upload a duplicate tarball, UploadToCPAN fails because > PAUSE says "no, that's a dupe," and it gives an error response.
I wonder if that's new-ish. Show quoted text
> Also, what if we just got that error message and instead of dying "509 > BAD QUERY" (or whatever) we turned it into "there's already a > duplicate, aborting."
I like that, but are we sure 509 is always a dupe message? I'm not opposed to patching PAUSE to give a better error that we could show to users, either.
Subject: Re: [rt.cpan.org #57841] Check for duplicate tarball name before uploading
Date: Thu, 25 Jul 2013 17:09:09 -0400
To: David Golden via RT <bug-Dist-Zilla [...] rt.cpan.org>
From: Ricardo Signes <rjbs [...] cpan.org>
Download (untitled) / with headers
text/plain 854b
* David Golden via RT <bug-Dist-Zilla@rt.cpan.org> [2013-07-25T16:38:08] Show quoted text
> Queue: Dist-Zilla > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57841 > > > On Thu Jul 25 16:07:09 2013, RJBS wrote:
> > Right now, if I upload a duplicate tarball, UploadToCPAN fails because > > PAUSE says "no, that's a dupe," and it gives an error response.
> > I wonder if that's new-ish.
I'm pretty sure it's been there for 5 years or so. Show quoted text
> > Also, what if we just got that error message and instead of dying "509 > > BAD QUERY" (or whatever) we turned it into "there's already a > > duplicate, aborting."
> > I like that, but are we sure 509 is always a dupe message?
I'm pretty darn sure, but I bet we can find out! ;) Show quoted text
> I'm not opposed to patching PAUSE to give a better error that we could show > to users, either.
That's good, too. -- rjbs
Download signature.asc
application/pgp-signature 490b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.