Skip Menu |
 

This queue is for tickets about the YUI-Loader CPAN distribution.

Report information
The Basics
Id: 57820
Status: resolved
Priority: 0/
Queue: YUI-Loader

People
Owner: Nobody in particular
Requestors: mcholste [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Bugs in YUI::Loader and feature requests
Date: Tue, 25 May 2010 11:52:43 -0500
To: bug-YUI-Loader [...] rt.cpan.org
From: Martin Holste <mcholste [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
Hi, I was creating a YUI::Loader module and found yours already complete and full-featured. However, there are some bugs. The module doesn't work at all in its current incarnation because of a type-oh on line 5 of YUI/Loader/List.pm which has "requires" instead of "required" which throws a Moose error and prevents anything from working. Because this is a run-time error, it didn't show up in the smoke tests. When the debug filter is on, it adds '-debug' to the css files, which don't have debug versions. This makes the debug filter useless. There are a lot of .js files referenced that have '-beta' and '-experimental' suffixes which are no longer valid. This breaks most modules. The uploader module requires three additional modules so it should be: 'requires': ['yahoo', 'dom', 'event', 'element'] The other issues aren't exactly bugs but more feature requests: Could you please add a paginator category to YUI/Loader/Catalog.pm and update the current YUI version in YUI/Loader.pm's LATEST_YUI_VERSION to be 2.8.1? I think this would work for Catalog.pm: 'paginator': { 'type': 'js', 'path': 'paginator/paginator-min.js', 'requires': ['event', 'element'], 'optional': ['selector'], 'skinnable': true } also "paginator":{name:"Paginator Control", type: "widget"} Thanks very much. --Martin
Download (untitled) / with headers
text/plain 301b
Martin, I put in a bunch of fixes for the issues you've mentioned, but in the process generally broke YUI::Loader The code is pretty ghastly, and could use a cleanup The best thing would be to run yuiloader.js in a js VM in perl, but ... Anyway, it's a work in progress Thanks for the report, Rob
Subject: Re: [rt.cpan.org #57820] Bugs in YUI::Loader and feature requests
Date: Thu, 27 May 2010 08:20:21 -0500
To: bug-YUI-Loader [...] rt.cpan.org
From: Martin Holste <mcholste [...] gmail.com>
Download (untitled) / with headers
text/plain 563b
The small changes I made got things working, would you like me to send you the diffs? On Wed, May 26, 2010 at 8:53 PM, Robert Krimen via RT <bug-YUI-Loader@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=57820 > > > Martin, > > I put in a bunch of fixes for the issues you've mentioned, but in the > process generally broke YUI::Loader > > The code is pretty ghastly, and could use a cleanup > > The best thing would be to run yuiloader.js in a js VM in perl, but ... > > Anyway, it's a work in progress > > Thanks for the report, > Rob >
Subject: Re: [rt.cpan.org #57820] Bugs in YUI::Loader and feature requests
Date: Thu, 27 May 2010 12:44:01 -0700
To: bug-YUI-Loader [...] rt.cpan.org
From: Robert Krimen <robertkrimen [...] gmail.com>
Download (untitled) / with headers
text/plain 320b
On Thu, May 27, 2010 at 6:20 AM, Martin Holste via RT < bug-YUI-Loader@rt.cpan.org> wrote: Show quoted text
> Queue: YUI-Loader > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57820 > > > The small changes I made got things working, would you like me to send > you the diffs? > >
Sure send those through. Thanks, Rob
Subject: Re: [rt.cpan.org #57820] Bugs in YUI::Loader and feature requests
Date: Thu, 27 May 2010 15:08:15 -0500
To: bug-YUI-Loader [...] rt.cpan.org
From: Martin Holste <mcholste [...] gmail.com>
Download (untitled) / with headers
text/plain 564b
Here are diffs for YUI/Loader/Catalog.pm and YUI/Loader/List.pm. On Thu, May 27, 2010 at 2:44 PM, Robert Krimen via RT <bug-YUI-Loader@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=57820 > > > On Thu, May 27, 2010 at 6:20 AM, Martin Holste via RT < > bug-YUI-Loader@rt.cpan.org> wrote: >
>>        Queue: YUI-Loader >>  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57820 > >> >> The small changes I made got things working, would you like me to send >> you the diffs? >> >>
> Sure send those through. > > Thanks, > Rob > >
Download Catalog.pm.diff
text/x-diff 2.3k

Message body is not shown because sender requested not to inline it.

Download List.pm.diff
text/x-diff 138b

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 519b
Martin, I abandoned a more comprehensive revamp I was going to do and instead applied your patches to 0.070. I also bumped the default YUI version to 2.8.1. This may break some things, I'm not entirely sure, since it looks like some file names had changed (css skins, specifically), but if your patches were working for you, great. The code is also available on github: http://github.com/robertkrimen/YUI-Loader if you wish to make more contributions. I put out 0.071 with your changes. Thanks for the patches, Rob


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.