Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 57640
Status: open
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.105
Fixed in: (no value)

History Show all quoted text — Show full headers
# Wed May 19 13:58:00 2010 dolmen [...] cpan.org - Ticket created
Subject: Subroutines::RequireFinalReturn should ignore DESTROY sub
Download (untitled) / with headers
text/plain 165b
The special sub DESTROY (object destructor) never returns a value. Subroutines::RequireFinalReturn should ignore it. -- Olivier Mengué - http://o.mengue.free.fr/
# Wed May 19 20:17:44 2010 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #57640] Subroutines::RequireFinalReturn should ignore DESTROY sub
Date: Wed, 19 May 2010 19:17:34 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Download (untitled) / with headers
text/plain 474b
On 5/19/10 12:58 PM, Olivier 'dolmen' Mengué via RT wrote: Show quoted text
> The special sub DESTROY (object destructor) never returns a value. > > Subroutines::RequireFinalReturn should ignore it.
Yes, it does. All subroutines return values. No exceptions. It's just that when it gets called as a destructor, the VM ignores the return value. Plus, there's nothing stopping someone from invoking DESTROY directly. Yes, it would be stupid to do so, but there's nothing preventing it.
# Wed May 19 20:17:45 2010 The RT System itself - Status changed from 'new' to 'open'
# Mon May 24 15:22:08 2010 dolmen [...] cpan.org - Correspondence added
Download (untitled) / with headers
text/plain 766b
Le Mer 19 Mai 2010 20:17:44, clonezone a écrit : Show quoted text
> On 5/19/10 12:58 PM, Olivier 'dolmen' Mengué via RT wrote:
> > The special sub DESTROY (object destructor) never returns a value. > > > > Subroutines::RequireFinalReturn should ignore it.
> > Yes, it does. All subroutines return values. No exceptions. It's > just that when it gets called as a destructor, the VM ignores the > return value. > > Plus, there's nothing stopping someone from invoking DESTROY directly. > Yes, it would be stupid to do so, but there's nothing preventing it.
OK. I understand. But could you add an option that would permit to relax that rules for a list of subs? Currently it is all or nothing. I propose: ignore_subs = DESTROY -- Olivier Mengué - http://o.mengue.free.fr/

This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.