Skip Menu |
 

This queue is for tickets about the MIME-tools CPAN distribution.

Report information
The Basics
Id: 57236
Status: rejected
Priority: 0/
Queue: MIME-tools

People
Owner: Nobody in particular
Requestors: rt.cpan.org [...] darkart.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
patch-lib-MIME-Parser.pm.allow_no_trailing_boundary.diff



Subject: patch to add an option to parse MIME messages without a trailing MIME boundary
Download (untitled) / with headers
text/plain 440b
Attached file is a patch for MIME::Tools 5.428 to add the ability to parse MIME messages that are missing their trailing MIME boundary. This ability is controlled by an option (allow_no_trailing_boundary(), as ignore_errors() is done). While missing the trailing MIME boundary is clearly an error from spec, we do see messages that appear to be otherwise intact and properly formed, and this patch allows us to parse those messages.
Subject: patch-lib-MIME-Parser.pm.allow_no_trailing_boundary.diff
--- lib/MIME/Parser.pm.orig 2010-05-03 16:02:52.000000000 -0700 +++ lib/MIME/Parser.pm 2010-05-04 11:08:48.000000000 -0700 @@ -249,6 +249,7 @@ $self->{MP5_UUDecode} = 0; $self->{MP5_MaxParts} = -1; $self->{MP5_TmpDir} = undef; + $self->{MP5_AllowNoTrailingBoundary} = 0; $self->interface(ENTITY_CLASS => 'MIME::Entity'); $self->interface(HEAD_CLASS => 'MIME::Head'); @@ -474,6 +475,28 @@ #------------------------------ +=item allow_no_trailing_boundary [YESNO] + +I<Instance method.> +Controls whether the parser will ignore the error of a missing +trailing MIME boundary. + +If YESNO is true, the parser will ignore missing trailing MIME +boundaries. +If YESNO is false (the default), a missing trailing MIME +boundary is a fatal error +With no argument, just returns the current setting. + +=cut + +sub allow_no_trailing_boundary { + my ($self, $yesno) = @_; + $self->{MP5_AllowNoTrailingBoundary} = $yesno if (@_ > 1); + $self->{MP5_AllowNoTrailingBoundary}; +} + +#------------------------------ + =item decode_bodies [YESNO] I<Instance method.> @@ -747,6 +770,7 @@ $eos_type = $part_rdr->eos_type; if ($eos_type eq 'DELIM') { $more_parts = 1 } elsif ($eos_type eq 'CLOSE') { $more_parts = 0; } + elsif ($self->allow_no_trailing_boundary() && $eos_type eq 'EOF') { $more_parts = 0; } else { $self->error("unexpected end of parts ". "before epilogue\n"); return 1; } @@ -806,9 +830,9 @@ ### ...and look at how we finished up. ### If we have bounds, we want DELIM or CLOSE. ### Otherwise, we want EOF (and that's all we'd get, anyway!). - if ($rdr->has_bounds) { + if ((!$self->allow_no_trailing_boundary()) && ($rdr->has_bounds)) { ($rdr->eos_type =~ /^(DELIM|CLOSE)$/) or - $self->error("part did not end with expected boundary\n"); + $self->error("part did not end with expected boundary\n"); } ### Flush and rewind encoded buffer, so we can read it:
Download (untitled) / with headers
text/plain 166b
Hi, Sorry; I have to reject this patch. MIME::tools is evil enough with all kinds of horrible legacy cruft. I don't really want to add any more. Regards, David.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.