Skip Menu |
 

This queue is for tickets about the XML-RSS CPAN distribution.

Report information
The Basics
Id: 5673
Status: resolved
Priority: 0/
Queue: XML-RSS

People
Owner: KELLAN [...] cpan.org
Requestors: rayg [...] varchars.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: patch with tweaks for rss 2.0
Download (untitled) / with headers
text/plain 381b
added support for self-contained items (i.e. no outside link- all information contained in the description). the spec allows the 'link' and 'title' to be optional if the description is present. i have a few feeds that do not have links and adding fake ones would only confuse the subscribers of the feed. also added a 'guid' field, which is the equivalent of isPermaLink="false"
Download RSS.pm.diff
text/x-diff 1.9k
--- /Library/Perl/5.8.1/XML/RSS.pm 2003-11-22 22:59:24.000000000 -0800 +++ RSS.pm 2004-03-14 21:02:36.000000000 -0800 @@ -1200,9 +1200,10 @@ foreach my $item (@{$self->{items}}) { if ($item->{title}) { $output .= '<item>'."\n"; - $output .= '<title>'.$self->encode($item->{title}).'</title>'."\n"; - $output .= '<link>'.$self->encode($item->{'link'}).'</link>'."\n"; - + $output .= '<title>'.$self->encode($item->{title}).'</title>'."\n" + if $item->{title}; + $output .= '<link>'.$self->encode($item->{'link'}).'</link>'."\n" + if $item->{link}; $output .= '<description>'.$self->encode($item->{description}).'</description>'."\n" if $item->{description}; @@ -1219,12 +1220,17 @@ # $output .= '<enclosure>'.$self->encode($item->{enclosure}).'</enclosure>'."\n" # if $item->{enclosure}; - # The unique identifier -- in this implementation we assume - # that it's a permalink to the item, so we always include the - # isPermaLink attribute. Also, I call it permaLink in the - # hash for purposes of clarity. - $output .= '<guid isPermaLink="true">'.$self->encode($item->{permaLink}).'</guid>'."\n" - if $item->{permaLink}; + # The unique identifier. Use 'permaLink' for an external + # identifier, or 'guid' for a internal string. + # (I call it permaLink in the hash for purposes of clarity.) + if ($item->{permaLink}) + { + $output .= '<guid isPermaLink="true">'.$self->encode($item->{permaLink}).'</guid>'."\n"; + } + elsif ($item->{guid}) + { + $output .= '<guid isPermaLink="false">'.$self->encode($item->{guid}).'</guid>'."\n"; + } $output .= '<pubDate>'.$self->encode($item->{pubDate}).'</pubDate>'."\n" if $item->{pubDate};
Download (untitled) / with headers
text/plain 519b
Thanks! I've added it, 1.05 should be out in the next day or so. [guest - Mon Mar 15 01:28:10 2004]: Show quoted text
> added support for self-contained items (i.e. no outside link- all > information contained in the description). the spec allows the > 'link' and 'title' to be optional if the description is present. i > have a few feeds that do not have links and adding fake ones would > only confuse the subscribers of the feed. > > also added a 'guid' field, which is the equivalent of > isPermaLink="false"


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.