This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id:
56474
Status:
resolved
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
florent.angly [...] gmail.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
0.95
Fixed in:
(no value)



Subject: Dependency check error fails to be triggered
Hi, When using the bundle_deps() feature of Module::Install::Bundle, the method scan_dependencies() of Module::Install::Admin::ScanDeps is eventually called. At line 32, it tries to check if the module is present in @INC and return an error if it is not: my @files = scalar $self->admin->find_in_inc($pkg) or die "Cannot find $pkg in \@INC"; In my experience, the test always evaluates as true and the error is not triggered. See attached test case and results. Florent
Subject: log.txt
$ perl -w Makefile.PL include /home/floflooo/Work/GAAS/program/bundle-test/inc/Module/Install.pm include inc/Module/Install/Metadata.pm include inc/Module/Install/Base.pm include inc/Module/Install/Makefile.pm Cannot determine author info from lib/HelloWorld.pm Cannot determine license info from lib/HelloWorld.pm Requiring a module that is not installed on the package admin's computer should results in 'Cannot find ABC::XYZ in @INC' include inc/Module/Install/Bundle.pm Use of uninitialized value $path in pattern match (m//) at /usr/share/perl5/Module/ScanDeps.pm line 484. Use of uninitialized value $path in pattern match (m//) at /usr/share/perl/5.10/File/Spec/Unix.pm line 121. Use of uninitialized value $input_file in pattern match (m//) at /usr/share/perl5/Module/ScanDeps.pm line 516. Use of uninitialized value $input_file in pattern match (m//) at /usr/share/perl5/Module/ScanDeps.pm line 522. Use of uninitialized value $path in pattern match (m//) at /usr/share/perl5/Module/ScanDeps.pm line 484. Use of uninitialized value $path in pattern match (m//) at /usr/share/perl/5.10/File/Spec/Unix.pm line 121. Use of uninitialized value $file in hash element at /usr/share/perl5/Module/ScanDeps.pm line 573. Use of uninitialized value $file in pattern match (m//) at /usr/share/perl5/Module/ScanDeps.pm line 576. Use of uninitialized value $file in open at /usr/share/perl5/Module/ScanDeps.pm line 579. Use of uninitialized value $file in concatenation (.) or string at /usr/share/perl5/Module/ScanDeps.pm line 579. Cannot open : No such file or directory at /usr/share/perl5/Module/ScanDeps.pm line 579.
Subject: Makefile.PL
use inc::Module::Install; name 'HelloWorld'; all_from 'lib/HelloWorld.pm'; print "Requiring a module that is not installed on the package admin's computer should results in 'Cannot find ABC::XYZ in \@INC'\n"; requires 'Win32::Symlink'; auto_bundle_deps; WriteAll;
Hi. Thanks for the quick follow-up. Fixed in the trunk. On 2010-4-10 Sat 21:55:40, FANGLY wrote:
Show quoted text
> Hi, > When using the bundle_deps() feature of Module::Install::Bundle, the > method scan_dependencies() of Module::Install::Admin::ScanDeps is > eventually called. > > At line 32, it tries to check if the module is present in @INC and > return an error if it is not: > > my @files = scalar $self->admin->find_in_inc($pkg) > or die "Cannot find $pkg in \@INC"; > > In my experience, the test always evaluates as true and the error is
not
Show quoted text
> triggered. See attached test case and results. > > Florent
Hi. Closed this ticket as fixed too. Thanks.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.