Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 56425
Status: open
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: avar [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.100960
Fixed in: (no value)



Subject: Dist::Zilla should detect & die if it's using old plugins
Download (untitled) / with headers
text/plain 418b
MakeMaker::Awesome was broken because it used FixedPrereqs, but I didn't notice because Dist::Zilla happily used FixedPrereqs.pm from an older DZ version that I had in my @INC. There should be a sanity check in Dist::Zilla that checks that all the plugins in core (or known to have been in core) have the same $VERSION value. Alteratively FixedPrereqs.pm could still be included with C<die "Use $this instead">.
Download (untitled) / with headers
text/plain 384b
On 2010-04-09 08:44:32, AVAR wrote: Show quoted text
> There should be a sanity check in Dist::Zilla that checks that all the > plugins in core (or known to have been in core) have the same $VERSION > value.
With the global config system overhauled, I should now be able to make a CorePlugin role that asserts that $self->VERSION must be eq Dist::Zilla->VERSION. So should anybody else. -- rjbs
Download (untitled) / with headers
text/plain 465b
I have added a branch on github, coreplugin, which adds the CorePlugin role. It's just Plugin, but also asserts that $self->VERSION eq $zilla->VERSION I'm not sure it's worth doing this, though. It will help with plugin version mismatches, but not roles. What if, for example, Dist::Zilla::Role::PPI left core. The same problem would arise. Once we're trying to inspect all roles, I think we're going to enter the realm of overcomplexity. Thoughts? -- rjbs


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.