Skip Menu |
 

This queue is for tickets about the HTTP-Proxy CPAN distribution.

Report information
The Basics
Id: 56259
Status: resolved
Priority: 0/
Queue: HTTP-Proxy

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
SREZIC [...] cpan.org
Cc: CARNIL [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.24
Fixed in: 0.302



Subject: Pod coverage test is failing with perl 5.12.0 RC0
Download (untitled) / with headers
text/plain 100b
See http://www.cpantesters.org/cpan/report/7033492 for a sample tester report. Regards, Slaven
Download (untitled) / with headers
text/plain 334b
Despite being marked as fixed in 0.300, this ticket is *not* fixed in 0.300, tests still fail for non-threaded perls. Sample fail report: http://www.cpantesters.org/cpan/report/caf9e7ba-c9c7-11e2-a19f-6eea979cd64d It would probably be a good idea to make pod tests author tests, they make user installs fail unnecessarily. Thanks,
Subject: Re: [rt.cpan.org #56259] Pod coverage test is failing with perl 5.12.0 RC0
Date: Tue, 16 Jul 2013 11:06:32 +0200
To: Andreas Koenig via RT <bug-HTTP-Proxy [...] rt.cpan.org>
From: "Philippe Bruhat (BooK)" <philippe.bruhat [...] free.fr>
Download (untitled) / with headers
text/plain 768b
On Tue, Jul 16, 2013 at 01:50:17AM -0400, Andreas Koenig via RT wrote: Show quoted text
> Queue: HTTP-Proxy > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=56259 > > > Despite being marked as fixed in 0.300, this ticket is *not* fixed in 0.300, tests still fail for non-threaded perls. Sample fail report: > > http://www.cpantesters.org/cpan/report/caf9e7ba-c9c7-11e2-a19f-6eea979cd64d > > It would probably be a good idea to make pod tests author tests, they make user installs fail unnecessarily. >
Isn't the issue the fact that the test fails when run with an unthreaded Perl? -- Philippe Bruhat (BooK) Putting beauty before brains is the surest way to wind up with neither. (Moral from Groo The Wanderer #24 (Epic))

On 2013-07-16 21:15:14, Philippe.Bruhat@free.fr wrote:
> Isn't the issue the fact that the test fails when run with an
> unthreaded Perl?

Yes... and no. The only failure is 02pod-coverage.t

Yes, the test fails doing Pod::Coverage for HTTP::Proxy::Engine::Threaded

However, thats immaterial: Because pod coverage tests really shouldn't be run on end user machines, because they cause problems for non-reasons that require user intervention to step around, which is unncessecary.

Here, Pod::Coverage is attempting to load the one module in the dist that requires threads, because its not smart enough not to, and that leads to the error.

 

( Even on the *best* of days, a Pod::Coverage test failing can be of no use to a user. "OH NOES DEVELOPER FORGOT TO DOCUMENT THIS METHOD, BETTER NOT INSTALL!  " ;) )


perl -d:Confess -T -Ilib t/02pod-coverage.t
1..18
ok 1 - Pod coverage on HTTP::Proxy
ok 2 - Pod coverage on HTTP::Proxy::HeaderFilter
ok 3 - Pod coverage on HTTP::Proxy::Engine
ok 4 - Pod coverage on HTTP::Proxy::FilterStack
ok 5 - Pod coverage on HTTP::Proxy::BodyFilter
ok 6 - Pod coverage on HTTP::Proxy::BodyFilter::tags
ok 7 - Pod coverage on HTTP::Proxy::BodyFilter::simple
ok 8 - Pod coverage on HTTP::Proxy::BodyFilter::lines
ok 9 - Pod coverage on HTTP::Proxy::BodyFilter::htmltext
ok 10 - Pod coverage on HTTP::Proxy::BodyFilter::htmlparser
ok 11 - Pod coverage on HTTP::Proxy::BodyFilter::complete
ok 12 - Pod coverage on HTTP::Proxy::BodyFilter::save
ok 13 - Pod coverage on HTTP::Proxy::Engine::ScoreBoard
ok 14 - Pod coverage on HTTP::Proxy::Engine::Legacy
ok 15 - Pod coverage on HTTP::Proxy::Engine::NoFork
not ok 16 - Pod coverage on HTTP::Proxy::Engine::Threaded
#   Failed test 'Pod coverage on HTTP::Proxy::Engine::Threaded'
#   at /home/kent/perl5/perlbrew/perls/perl-5.20.0/lib/site_perl/5.20.0/Test/Pod/Coverage.pm line 126.
# HTTP::Proxy::Engine::Threaded: requiring 'HTTP::Proxy::Engine::Threaded' failed
ok 17 - Pod coverage on HTTP::Proxy::HeaderFilter::simple
ok 18 - Pod coverage on HTTP::Proxy::HeaderFilter::standard
# Looks like you failed 1 test of 18.
 

Download (untitled) / with headers
text/plain 407b
On Wed Jun 18 15:27:34 2014, KENTNL wrote: Show quoted text
> On 2013-07-16 21:15:14, Philippe.Bruhat@free.fr wrote:
> > Isn't the issue the fact that the test fails when run with an > > unthreaded Perl?
> > ( Even on the *best* of days, a Pod::Coverage test failing can be of > no use to > a user. "OH NOES DEVELOPER FORGOT TO DOCUMENT THIS METHOD, BETTER NOT > INSTALL! > " ;) ) >
This was fixed by moving to dzil. :-)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.