Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 55667
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: JDB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.3603
Fixed in: (no value)



Subject: Don't call link_executable() on Windows
Download (untitled) / with headers
text/plain 607b
ExtUtils::CBuilder is still skipping all tests for link_executable() on Windows because it doesn't have a platformer/compiler specific implementation for it yet. The naive implementation in ExtUtils::CBuilder::Base is good enough most of the time for the Module::Build test, but does fail for the 64-bit Windows 2003 Platform SDK compiler. Module::Build doesn't even use link_executable; it only calls it to determine if the tmp directory is executable, if I understand this correctly. This isn't applicable to Windows, so I suggest that the call to link_executable() should simply be skipped on Windows.
Subject: link_exe.patch
Download link_exe.patch
text/x-diff 396b
--- a/t/lib/MBTest.pm~ 2009-12-21 11:45:39.000000000 -0800 +++ b/t/lib/MBTest.pm 2010-01-08 17:23:12.249843100 -0800 @@ -201,6 +201,8 @@ my $have_c_compiler; stderr_of( sub {$have_c_compiler = $mb->have_c_compiler} ); + # XXX link_executable() is not yet implemented for Windows + return ($have_c_compiler, 1) if $^O eq "MSWin32"; # check noexec tmpdir my $tmp_exec;
Thanks. Applied to repo.
Download (untitled) / with headers
text/plain 103b
Now that there has been a stable Module::Build release, I'm marking this "patched" issue as "resolved".


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.