Skip Menu |
 

This queue is for tickets about the Smolder CPAN distribution.

Report information
The Basics
Id: 55514
Status: open
Priority: 0/
Queue: Smolder

People
Owner: Nobody in particular
Requestors: pete [...] peteleonard.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.51
Fixed in: 1.51



Subject: URLs broken in RSS and Email
Download (untitled) / with headers
text/plain 150b
As reported originally in GitHub, URLs in both RSS feeds and Emails were broken. This patch fixes it for RSS feeds, emails, and in the documentation.
Subject: Smolder_151_URL_fix.patch
diff -crB Smolder-1.51/htdocs/js/smolder.js Smolder-1.51a/htdocs/js/smolder.js *** Smolder-1.51/htdocs/js/smolder.js 2009-12-15 19:50:19.000000000 -0500 --- Smolder-1.51a/htdocs/js/smolder.js 2010-03-12 20:49:38.000000000 -0500 *************** *** 813,819 **** new Ajax.Autocompleter( 'platform', 'platform_auto_complete', ! '/app/developer_projects/platform_options' ); }, --- 813,819 ---- new Ajax.Autocompleter( 'platform', 'platform_auto_complete', ! '/app/projects/platform_options' ); }, *************** *** 821,827 **** new Ajax.Autocompleter( 'architecture', 'architecture_auto_complete', ! '/app/developer_projects/architecture_options' ); }, --- 821,827 ---- new Ajax.Autocompleter( 'architecture', 'architecture_auto_complete', ! '/app/projects/architecture_options' ); }, Only in Smolder-1.51a/lib/Smolder/Control: #Projects.pm# diff -crB Smolder-1.51/lib/Smolder/Control/Projects.pm Smolder-1.51a/lib/Smolder/Control/Projects.pm *** Smolder-1.51/lib/Smolder/Control/Projects.pm 2009-12-15 19:50:19.000000000 -0500 --- Smolder-1.51a/lib/Smolder/Control/Projects.pm 2010-03-12 20:53:26.000000000 -0500 *************** *** 812,820 **** foreach my $report (@reports) { my $link = ! Smolder::Util::url_base() . '/app/' ! . ($project->public ? 'public' : 'developer') ! . '_projects/smoke_report/' . $report->id; $feed->add_entry( title => '#' --- 812,818 ---- foreach my $report (@reports) { my $link = ! Smolder::Util::url_base() . '/app/projects/smoke_report/' . $report->id; $feed->add_entry( title => '#' diff -crB Smolder-1.51/lib/Smolder/Manual.pm Smolder-1.51a/lib/Smolder/Manual.pm *** Smolder-1.51/lib/Smolder/Manual.pm 2009-12-15 19:50:19.000000000 -0500 --- Smolder-1.51a/lib/Smolder/Manual.pm 2010-03-12 20:47:57.000000000 -0500 *************** *** 182,188 **** to do it just using C<curl> from the command line. LWP::UserAgent->new()->post( ! 'http://smolder.project.org/app/developer_projects/add_report/$project_id', Content_Type => 'form-data', Content => [ architecture => '386', --- 182,188 ---- to do it just using C<curl> from the command line. LWP::UserAgent->new()->post( ! 'http://smolder.project.org/app/projects/add_report/$project_id', Content_Type => 'form-data', Content => [ architecture => '386', Only in Smolder-1.51a/templates/Email: #smoke_report_full.tmpl# diff -crB Smolder-1.51/templates/Email/smoke_report_full.tmpl Smolder-1.51a/templates/Email/smoke_report_full.tmpl *** Smolder-1.51/templates/Email/smoke_report_full.tmpl 2009-12-15 19:50:19.000000000 -0500 --- Smolder-1.51a/templates/Email/smoke_report_full.tmpl 2010-03-12 20:45:17.000000000 -0500 *************** *** 18,24 **** <div id="content"> <div id="page_title"> <h1>Test Details #[% report.id %]</h1> ! <a href="[% url_base %]/app/developer_projects/report_details/[% report.id %]">[View Full Report]</a> </div> <div class="tap"> --- 18,24 ---- <div id="content"> <div id="page_title"> <h1>Test Details #[% report.id %]</h1> ! <a href="[% url_base %]/app/projects/report_details/[% report.id %]">[View Full Report]</a> </div> <div class="tap"> diff -crB Smolder-1.51/templates/Email/smoke_report_link.tmpl Smolder-1.51a/templates/Email/smoke_report_link.tmpl *** Smolder-1.51/templates/Email/smoke_report_link.tmpl 2009-12-15 19:50:19.000000000 -0500 --- Smolder-1.51a/templates/Email/smoke_report_link.tmpl 2010-03-12 20:45:36.000000000 -0500 *************** *** 3,9 **** at <a href="[% url_base %]">[% url_base %]</a>. <br /> You can find the details of this test at ! [% SET my_url = "$url_base/app/developer_projects/smoke_report/${report.id}" %] <a href="[% my_url %]">[% my_url %]</a>. <br /> --- 3,9 ---- at <a href="[% url_base %]">[% url_base %]</a>. <br /> You can find the details of this test at ! [% SET my_url = "$url_base/app/projects/smoke_report/${report.id}" %] <a href="[% my_url %]">[% my_url %]</a>. <br />
From: erik [...] q32.com
Download (untitled) / with headers
text/plain 248b
On Fri Mar 12 21:23:10 2010, peterleonard wrote: Show quoted text
> As reported originally in GitHub, URLs in both RSS feeds and Emails were > broken. > > This patch fixes it for RSS feeds, emails, and in the documentation.
I applied this patch, and it worked.
Download (untitled) / with headers
text/plain 448b
Le Ven 12 Mar 2010 21:23:10, peterleonard a écrit : Show quoted text
> As reported originally in GitHub, URLs in both RSS feeds > and Emails were broken. > > This patch fixes it for RSS feeds, emails, and in the > documentation.
As far as I can say, this patch has been applied at some point, and is part of the 1.52 release » https://metacpan.org/release/SAPER/Smolder-1.52 » https://github.com/Smolder/smolder/tree/1.52 -- Close the world, txEn eht nepO.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.