Skip Menu |
 

This queue is for tickets about the CPAN CPAN distribution.

Report information
The Basics
Id: 55452
Status: open
Priority: 0/
Queue: CPAN

People
Owner: Nobody in particular
Requestors: NKH [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.9402
Fixed in: (no value)



Subject: upgrade stops at the first failure
Download (untitled) / with headers
text/plain 104b
Command 'upgrade' stops at the first failing module installation making it more or less totally useless.
also broken in CPAN-1.94_56
Subject: Re: [rt.cpan.org #55452] upgrade stops at the first failure
Date: Wed, 10 Mar 2010 18:10:29 -0500
To: bug-CPAN <bug-CPAN [...] rt.cpan.org>
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 243b
On Wed, Mar 10, 2010 at 5:13 PM, NKH via RT <bug-CPAN@rt.cpan.org> wrote: Show quoted text
> Command 'upgrade' stops at the first failing module installation making > it more or less totally useless.
What is the result of "o conf halt_on_failure" ? -- David
Download (untitled) / with headers
text/plain 191b
Show quoted text
> What is the result of "o conf halt_on_failure" ?
The result is '1'. If setting it to '0' would fix this problem, I wonder if 'upgrade' shouldn't have a separate configuration variable.
Subject: Re: [rt.cpan.org #55452] upgrade stops at the first failure
Date: Thu, 11 Mar 2010 06:34:35 -0500
To: bug-CPAN [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 685b
On Thu, Mar 11, 2010 at 2:35 AM, NKH via RT <bug-CPAN@rt.cpan.org> wrote: Show quoted text
>       Queue: CPAN >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55452 > >
>> What is the result of "o conf halt_on_failure" ?
> > The result is '1'. > > If setting it to '0' would fix this problem, I wonder if 'upgrade' > shouldn't have a separate configuration variable.
I think we have enough configuration variables already. Andreas -- my thoughts: (1) Just locally disable it (potential surprise if someone wants the behavior) (2) Warn the user (but possibly lost in scrollback) (3) Prompt -- "You've request halt_on_failure -- do you want to disable it during 'upgrade'"? -- David
Download (untitled) / with headers
text/plain 958b
Show quoted text
> I think we have enough configuration variables already.
I agree. Show quoted text
> Andreas -- my thoughts: > > (1) Just locally disable it (potential surprise if someone wants the > behavior)
I firmly believe in the principle of least surprise so I don't like this solution at all. Show quoted text
> (2) Warn the user (but possibly lost in scrollback)
This is also a surprise. No? Show quoted text
> (3) Prompt -- "You've request halt_on_failure -- do you want to > disable it during 'upgrade'"?
This one gets my vote. Maybe a question that doesn't expect the user to know what 'halt_on_failure' means would be better. IE: it was set by default for me and you told me about it. I doubt all cpan user will get the same exceptional 'level of service'. I also believe that an upgrade status should be given after the upgrade as well as a link to a log file containing all the output generated during the upgrade. Btw, does cpan log anything during its normal (non upgrade) usage? Cheers, Nadim.
Subject: Re: [rt.cpan.org #55452] upgrade stops at the first failure
Date: Thu, 11 Mar 2010 18:35:31 -0500
To: bug-CPAN <bug-CPAN [...] rt.cpan.org>
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 420b
On Thu, Mar 11, 2010 at 6:21 PM, NKH via RT <bug-CPAN@rt.cpan.org> wrote: Show quoted text
> This one gets my vote. Maybe a question that doesn't expect the user to > know what 'halt_on_failure' means would be better. IE: it was set by > default for me and you told me about it. I doubt all cpan user will get > the same exceptional 'level of service'.
halt_on_failure defaults to 0. So you or a sysadmin must have set it to 1. David
Download (untitled) / with headers
text/plain 291b
I like none of the three options. What about (4) whenever halt_on_failure causes a halt it must indicate that in the fail summary. That way every user who has configured halt_on_failure once upon the time for some reason gets what he asked for but is also reminded about the configuration.
Download (untitled) / with headers
text/plain 396b
I mean, currently I see: Running make install make test had returned bad status, won't install without force Stopping: 'install' failed for 'M/MI/MIYAGAWA/Plack-0.9915.tar.gz'. Failed during this command: MIYAGAWA/Plack-0.9915.tar.gz : make_test NO and the "Stopping" line is red. It should probably read: Halting last command (configuration has halt_on_failure set): ...
Any chance this will be fixed soon? I'd jump in if I knew where to start.
Subject: Re: [rt.cpan.org #55452] upgrade stops at the first failure
Date: Tue, 25 May 2010 07:40:34 -0400
To: bug-CPAN [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 352b
On Tue, May 25, 2010 at 3:31 AM, NKH via RT <bug-CPAN@rt.cpan.org> wrote: Show quoted text
>       Queue: CPAN >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55452 > > > Any chance this will be fixed soon? > > I'd jump in if I knew where to start.
Grep for 'halt_on_failure' in CPAN::Shell and send patch with a more sensible error message? -- David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.