Skip Menu |
 

This queue is for tickets about the Is-Kennitala CPAN distribution.

Report information
The Basics
Id: 55252
Status: resolved
Priority: 0/
Queue: Is-Kennitala

People
Owner: Nobody in particular
Requestors: pne [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Persons born on the 30th/31st mistakenly identified as companies
Download (untitled) / with headers
text/plain 480b
Judging by http://cpansearch.perl.org/src/AVAR/Business-IS-PIN-0.05/PIN.pm, a "person" is someone whose kennitala starts with 0,1,2 while a "company" is someone whose kennitala starts with 3,4,5. What about someone born on the 30th of March or the 31st of January of a year? Won't their kennitala start with a 3 even though they are a person? Perhaps the easiest fix is to relace [0-2] with (?:[0-2]|3[01]) and [3-5] with (?:3[2-9]|[45]) in "person" and "company", respectively.
Download (untitled) / with headers
text/plain 612b
On Fri Mar 05 05:33:28 2010, PNE wrote: Show quoted text
> Judging by > http://cpansearch.perl.org/src/AVAR/Business-IS-PIN-0.05/PIN.pm, a > "person" is someone whose kennitala starts with 0,1,2 while a
"company" Show quoted text
> is someone whose kennitala starts with 3,4,5. > > What about someone born on the 30th of March or the 31st of January of
a Show quoted text
> year? Won't their kennitala start with a 3 even though they are a
person? Show quoted text
> > Perhaps the easiest fix is to relace [0-2] with (?:[0-2]|3[01]) and > [3-5] with (?:3[2-9]|[45]) in "person" and "company", respectively.
Oops, yes that's a silly bug. I'll fix it. Thanks for the report.
Download (untitled) / with headers
text/plain 730b
On Fri Mar 05 05:51:19 2010, AVAR wrote: Show quoted text
> On Fri Mar 05 05:33:28 2010, PNE wrote:
> > Judging by > > http://cpansearch.perl.org/src/AVAR/Business-IS-PIN-0.05/PIN.pm, a > > "person" is someone whose kennitala starts with 0,1,2 while a
> "company"
> > is someone whose kennitala starts with 3,4,5. > > > > What about someone born on the 30th of March or the 31st of January
of Show quoted text
> a
> > year? Won't their kennitala start with a 3 even though they are a
> person?
> > > > Perhaps the easiest fix is to relace [0-2] with (?:[0-2]|3[01]) and > > [3-5] with (?:3[2-9]|[45]) in "person" and "company", respectively.
> > Oops, yes that's a silly bug. I'll fix it. > > Thanks for the report.
Fixed in 0.06, it'll be on CPAN soon.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.