Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTML-Tidy CPAN distribution.

Report information
The Basics
Id: 5469
Status: resolved
Priority: 0/
Queue: HTML-Tidy

People
Owner: Nobody in particular
Requestors: crazyinsomniac [...] yahoo.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Date: Thu, 26 Feb 2004 23:39:49 -0800 (PST)
From: DH <crazyinsomniac [...] yahoo.com>
Subject: how-to build HTML-Tidy on win32 and some notes/questions
To: bug-html-tidy [...] rt.cpan.org
Download (untitled) / with headers
text/plain 7.2k
First thing I did was get rid of #include "ppport.h" from Tidy.xs because it prevented compilation. I'd try getting a newer ppport.h or getting rid of it all together (maybe make it a conditional #include). Then I modified Makefile.PL so it points to libtidy.lib, and then I had to recompile libtidy.lib with the /MD flag ( tidy/build/msvc/Makefile.vc6 ) because that's what perl was compiled with (important). Now, in the docs you say "The tidy folks don't distribute a libtidy distribution..." but they actually do ===> http://tidy.sourceforge.net/src/tidy_src.tgz Also, I already have HTML::Tidy from http://users.rcn.com/creitzel/tidy.html#tidyperl which is a SWIG generated wrapper around the c++ wrapper of tidyperl. It's highly undocumented... but I still have it installed and I know Corion (perlmonk) and a few others do as well ... it's a concern. also, you may want to contact http://sourceforge.net/projects/ptidy/. now something else you can actually work on, your test suite :) C:\new\HTML-Tidy-1.00>nmake test TEST_VERBOSE=1 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. Running Mkbootstrap for HTML::Tidy () C:\Perl\bin\perl.exe -MExtUtils::Command -e chmod 644 Tidy.bs link -out:blib\arch\auto\HTML\Tidy\Tidy.dll -dll -nologo -nodefaultlib -release -libpath:"C:\Perl\lib\CORE" -m achine:x86 Tidy.obj C:\Perl\lib\CORE\perl56.lib C:\new\tidy_src\tidy\build\msvc\release\\libtidy.lib E:\PROGRA~1\MICRO S~4\VC98\LIB\oldnames.lib E:\PROGRA~1\MICROS~4\VC98\LIB\kernel32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\user32.lib E:\PROGRA~ 1\MICROS~4\VC98\LIB\gdi32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\winspool.lib E:\PROGRA~1\MICROS~4\VC98\LIB\comdlg32.lib E:\P ROGRA~1\MICROS~4\VC98\LIB\advapi32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\shell32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\ole32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\oleaut32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\netapi32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\uui d.lib E:\PROGRA~1\MICROS~4\VC98\LIB\wsock32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\mpr.lib E:\PROGRA~1\MICROS~4\VC98\LIB\winm m.lib E:\PROGRA~1\MICROS~4\VC98\LIB\version.lib E:\PROGRA~1\MICROS~4\VC98\LIB\odbc32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\o dbccp32.lib E:\PROGRA~1\MICROS~4\VC98\LIB\msvcrt.lib -def:Tidy.def Creating library blib\arch\auto\HTML\Tidy\Tidy.lib and object blib\arch\auto\HTML\Tidy\Tidy.exp C:\Perl\bin\perl.exe -MExtUtils::Command -e chmod 755 blib\arch\auto\HTML\Tidy\Tidy.dll C:\Perl\bin\perl.exe -MExtUtils::Command -e cp Tidy.bs blib\arch\auto\HTML\Tidy\Tidy.bs C:\Perl\bin\perl.exe -MExtUtils::Command -e chmod 644 blib\arch\auto\HTML\Tidy\Tidy.bs C:\Perl\bin\perl.exe -MExtUtils::Command -e cp bin/webtidy blib\script\webtidy pl2bat.bat blib\script\webtidy C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(1, 'blib\lib', 'blib\arch')" t\00.load.t t\ext ra-quote.t t\ignore-text.t t\ignore.t t\levels.t t\message.t t\perfect.t t\pod-coverage.t t\pod.t t\simple.t t\too-many- titles.t t\00.load............1..2 ok 1 - use HTML::Tidy; ok 2 - use HTML::Tidy::Message; ok t\extra-quote........1..4 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy ok 3 not ok 4 - Matching warnings # Failed test (t\extra-quote.t at line 31) # Structures begin differing at: ' $got->[0] = '- (4:1) Warning: <img> unexpected or duplicate quote mark # $expected->[0] = '- (4:1) Warning: <img> unexpected or duplicate quote mark' # Looks like you failed 1 tests of 4. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 4 Failed 1/4 tests, 75.00% okay t\ignore-text........1..3 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy not ok 3 - Matching warnings # Failed test (t\ignore-text.t at line 28) # Structures begin differing at: ' $got->[0] = 'DATA (24:78) Warning: unescaped & which should be written as &amp; # $expected->[0] = 'DATA (24:78) Warning: unescaped & which should be written as &amp;' # Looks like you failed 1 tests of 3. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 3 Failed 1/3 tests, 66.67% okay t\ignore.............1..7 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy not ok 3 - Matching warnings # Failed test (t\ignore.t at line 33) # Structures begin differing at: ' $got->[0] = '- (1:1) Warning: missing <!DOCTYPE> declaration # $expected->[0] = '- (1:1) Warning: missing <!DOCTYPE> declaration' ok 4 - The object isa HTML::Tidy not ok 5 - Matching errors # Failed test (t\ignore.t at line 44) # Structures begin differing at: ' $got->[0] = '- (23:1) Error: <bogotag> is not recognized! # $expected->[0] = '- (23:1) Error: <bogotag> is not recognized!' ok 6 - The object isa HTML::Tidy ok 7 - Throws an error # Looks like you failed 2 tests of 7. dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 3, 5 Failed 2/7 tests, 71.43% okay t\levels.............1..3 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy not ok 3 - Matching messages # Failed test (t\levels.t at line 23) # Structures begin differing at: ' $got->[0] = '- (1:1) Warning: missing <!DOCTYPE> declaration # $expected->[0] = '- (1:1) Warning: missing <!DOCTYPE> declaration' # Looks like you failed 1 tests of 3. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 3 Failed 1/3 tests, 66.67% okay t\message............1..16 ok 1 - use HTML::Tidy; ok 2 - use HTML::Tidy::Message; ok 3 - The object isa HTML::Tidy::Message ok 4 ok 5 ok 6 ok 7 ok 8 ok 9 ok 10 - The object isa HTML::Tidy::Message ok 11 ok 12 ok 13 ok 14 ok 15 ok 16 ok t\perfect............1..3 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy ok 3 - Should have no messages ok t\pod-coverage.......1..2 ok 1 - Pod coverage on HTML::Tidy ok 2 - Pod coverage on HTML::Tidy::Message ok t\pod................1..3 ok 1 - blib/script/webtidy ok 2 - blib/lib/HTML/Tidy.pm ok 3 - blib/lib/HTML/Tidy/Message.pm ok t\simple.............1..4 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy ok 3 ok 4 - Cleared the messages ok t\too-many-titles....1..3 ok 1 - use HTML::Tidy; ok 2 - The object isa HTML::Tidy not ok 3 - Matching warnings # Failed test (t\too-many-titles.t at line 20) # Structures begin differing at: ' $got->[0] = '- (1:1) Warning: missing <!DOCTYPE> declaration # $expected->[0] = '- (1:1) Warning: missing <!DOCTYPE> declaration' # Looks like you failed 1 tests of 3. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 3 Failed 1/3 tests, 66.67% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t\extra-quote.t 1 256 4 1 25.00% 4 t\ignore-text.t 1 256 3 1 33.33% 3 t\ignore.t 2 512 7 2 28.57% 3 5 t\levels.t 1 256 3 1 33.33% 3 t\too-many-titles.t 1 256 3 1 33.33% 3 Failed 5/11 test scripts, 54.55% okay. 6/50 subtests failed, 88.00% okay. NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0x2' Stop. Show quoted text
__________________________________ Do you Yahoo!? Get better spam protection with Yahoo! Mail. http://antispam.yahoo.com/tools
Date: Sun, 29 Feb 2004 11:34:39 -0600
From: Andy Lester <andy [...] petdance.com>
To: "crazyinsomniac [...] yahoo.com via RT" <bug-HTML-Tidy [...] rt.cpan.org>
CC: "AdminCc of cpan Ticket #5469": ;
Subject: Re: [cpan #5469] how-to build HTML-Tidy on win32 and some notes/questions
RT-Send-Cc:
Download (untitled) / with headers
text/plain 1.3k
Show quoted text
> First thing I did was get rid of > #include "ppport.h" > from Tidy.xs because it prevented compilation. > I'd try getting a newer ppport.h or getting rid of it all together > (maybe make it a conditional #include).
Got rid of it entirely. Show quoted text
> Then I modified Makefile.PL so it points to libtidy.lib, > and then I had to recompile libtidy.lib with the /MD flag > ( tidy/build/msvc/Makefile.vc6 ) > because that's what perl was compiled with (important).
I don't know how I'd patch this in the Makefile.PL. Specific example would help. Show quoted text
> Now, in the docs you say "The tidy folks don't distribute a libtidy distribution..." > but they actually do ===> > http://tidy.sourceforge.net/src/tidy_src.tgz
Now noted. Show quoted text
> Also, I already have HTML::Tidy from > http://users.rcn.com/creitzel/tidy.html#tidyperl > which is a SWIG generated wrapper around the c++ wrapper of tidyperl.
Understood. I'm going ahead with this one, as I feel like it's an improvement over that one. I'm still looking to see what I can get from there and incorporate. Show quoted text
> now something else you can actually work on, your test suite :)
Ah, it seems that libtidy doesn't change its line endings based on platforms. I changed HTML::Tidy so that it splits on Ctrl-J instead of \n. Thanks, xoa -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.