| Subject: | Incompatibility with Date::Manip 6.x |
Date::Manip 6.x is a major rewrite, and has included the removal of the
TodayIsMidnight configuration variable. This leads to test failures in
grepmail such as:
# Failed test 't/temp/date_manip_none.stderr compared to t/results/none'
# at t/date_manip.t line 132.
# Structures begin differing at:
# $got->[0] = 'ERROR: [config_var] invalid config variable:
todayismidnight
# '
# $expected->[0] = Does not exist
# Failed test 't/temp/date_manip_invalid_date_1.stderr compared to
t/results/invalid_date_1'
# at t/date_manip.t line 132.
# Structures begin differing at:
# $got->[0] = 'ERROR: [config_var] invalid config variable:
todayismidnight
# '
# $expected->[0] = 'grepmail: "armageddon" is not a valid date
# '
# Failed test 't/temp/date_manip_invalid_date_1.stderr compared to
t/results/invalid_date_1'
# at t/date_manip.t line 132.
# Structures begin differing at:
# $got->[0] = 'ERROR: [config_var] invalid config variable:
todayismidnight
# '
# $expected->[0] = 'grepmail: "armageddon" is not a valid date
# '
# Failed test 't/temp/date_manip_none.stderr compared to t/results/none'
# at t/date_manip.t line 132.
# Structures begin differing at:
# $got->[0] = 'ERROR: [config_var] invalid config variable:
todayismidnight
# '
# $expected->[0] = Does not exist
# Looks like you failed 4 tests of 9.
t/date_manip.t ..............
Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/9 subtests
Attached patch fixes the problem for me, without breaking compatibility
with older Date::Manip versions.
| Subject: | grepmail-5.3034-date-manip-6.patch |
--- grepmail-5.3034/grepmail.orig 2009-08-16 21:26:03.000000000 +0100
+++ grepmail-5.3034/grepmail 2010-02-15 13:46:52.674267600 +0000
@@ -394,7 +394,7 @@
if (eval 'require Date::Manip')
{
my ($version_number) = $Date::Manip::VERSION =~ /^(\d+\.\d+)/;
- Date::Manip::Date_Init("TodayIsMidnight=1") if $version_number >= 5.43;
+ Date::Manip::Date_Init("TodayIsMidnight=1") if ($version_number >= 5.43 && $version_number < 6);
}
}