Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 54518
Status: resolved
Priority: 0/
Queue: Test-Harness

People
Owner: Nobody in particular
Requestors: schwigon [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 3.17
  • 3.17_01
  • 3.17_02
  • 3.17_03
  • 3.17_04
  • 3.18
  • 3.19
  • 3.20
  • 3.21
Fixed in: (no value)



Subject: TAP13 regression with plan at end
Download (untitled) / with headers
text/plain 1.7k
Hi! Currently the TAP::Parser does not recognize a plan at the end of TAP if embedded YAML is used and TAP Version 13 is activated. It reports both these Parse Errors at once: More than one plan found in TAP output No plan found in TAP output The parsing itself seems to recognize the plan because it reports "All 3 subtests passed". See the 4 attached example scripts. One of them ("lazyplan_withyaml_tap13.t") does reveal the bug. $ prove \ normalplan_withyaml.t \ lazyplan_noyaml.t \ lazyplan_withyaml_tap13.t \ lazyplan_withyaml_tap12.t normalplan_withyaml.t ...... ok lazyplan_noyaml.t .......... ok lazyplan_withyaml_tap13.t .. All 3 subtests passed lazyplan_withyaml_tap12.t .. ok Test Summary Report ------------------- lazyplan_withyaml_tap13.t (Wstat: 0 Tests: 3 Failed: 0) Parse errors: More than one plan found in TAP output No plan found in TAP output Files=4, Tests=12, 1 wallclock secs ( 0.10 usr 0.03 sys + 0.02 cusr 0.01 csys = 0.16 CPU) Result: FAIL ------------------------------------------------------------- Please, if by any chance you have time to investigate this, I would really much appreciate it, as it becomes a common use-case in my test infrastructure at work (a huuuuge company, hey, really :-)). I am also willing to contribute; unfortunately I didn't understand the TAP::Parser code yet, nor even the test code but if I can help with something anyway... Please email me if I should come to IRC or similar for this. I am GMT+1 timezone. ------------------------------------------------------------- Thanks and kind regards, Steffen -- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/> Deutscher Perl-Workshop <http://www.perl-workshop.de/>
Subject: lazyplan_withyaml_tap13.t
#! perl print " TAP Version 13 ok - test suite started ok - bogomips --- Bogomips: 5226.88 ... ok - affe zomtec 1..3 ";
Subject: normalplan_withyaml.t
#! perl print " TAP Version 13 1..3 ok - test suite started ok - bogomips --- Bogomips: 5226.88 ... ok - affe zomtec ";
Subject: lazyplan_noyaml.t
Download lazyplan_noyaml.t
text/x-perl 95b
#! perl print " TAP Version 13 ok - test suite started ok - bogomips ok - affe zomtec 1..3 ";
Subject: lazyplan_withyaml_tap12.t
#! perl print " ok - test suite started ok - bogomips --- Bogomips: 5226.88 ... ok - affe zomtec 1..3 ";
CC: schwigon [...] cpan.org
Subject: Re: [rt.cpan.org #54518] AutoReply: TAP13 regression with plan at end
Date: Fri, 12 Feb 2010 09:44:26 +0100
To: bug-Test-Harness [...] rt.cpan.org
From: Steffen Schwigon <ss5 [...] renormalist.net>
Download (untitled) / with headers
text/plain 682b
"Bugs in Test-Harness via RT" <bug-Test-Harness@rt.cpan.org> writes: Show quoted text
> I am also willing to contribute; unfortunately I didn't > understand the TAP::Parser code yet
To drive this further and get me into contribution mode: Could you or someone else please just drop me meditations about where this bug could be located, so that I can start reading more focused in TAP::Parser source. Whatever hints you have, like which module, which subs, grammar bug vs wrong yaml handling, braindumps or whatever theories you have in mind. Just to help me get involved. Raw and uncensored. Feel free to reply privately. Thanks and regards, Steffen -- Steffen Schwigon <ss5@renormalist.net>
Download (untitled) / with headers
text/plain 306b
Please have a look to my suggested fix in http://github.com/renormalist/Test-Harness/tree/rt-54518 Also sent you a github pull request. Kind regards, Steffen -- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/> Deutscher Perl-Workshop <http://www.perl-workshop.de/>
Download (untitled) / with headers
text/plain 235b
On Mon Feb 22 11:09:39 2010, SCHWIGON wrote: Show quoted text
> Please have a look to my suggested fix in > > http://github.com/renormalist/Test-Harness/tree/rt-54518 > > Also sent you a github pull request.
Thanks Steffen. I've applied your fix.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.