Skip Menu |
 

This queue is for tickets about the PAR-Dist CPAN distribution.

Report information
The Basics
Id: 54145
Status: open
Priority: 0/
Queue: PAR-Dist

People
Owner: Nobody in particular
Requestors: csjewell [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 0.46
  • 0.47
Fixed in: (no value)



Subject: PAR::Dist does not try to verify that "Build" is not a directory before trying to execute it.
Download (untitled) / with headers
text/plain 758b
This issue makes it impossible to package the current version of Wx (0.96), as it includes a "build" directory, as per the output below. [output starts after "perl Makefile.PL" has been executed in that directory.] This should be simple enough to fix that I can send a patch, if you'd like and if it'd get fixed even faster. C:\Wx-0.96>perl -MPAR::Dist -eblib_to_par Can't open perl script "Build": Permission denied No such file or directory at C:/strawberry/perl/site/lib/PAR/Dist.pm line 169. C:\Wx-0.96>dir B* Volume in drive C has no label. Volume Serial Number is 6C4E-EE8B Directory of C:\Wx-0.96 01/29/2010 11:37 PM <DIR> build 0 File(s) 0 bytes 1 Dir(s) 2,455,281,664 bytes free
Subject: Re: [rt.cpan.org #54145] PAR::Dist does not try to verify that "Build" is not a directory before trying to execute it.
Date: Sat, 30 Jan 2010 12:34:06 +0100 (CET)
To: bug-PAR-Dist [...] rt.cpan.org
From: "Steffen Mueller" <smueller [...] cpan.org>
Download (untitled) / with headers
text/plain 1.4k
Hi Curtis, Show quoted text
> Sat Jan 30 01:49:24 2010: Request 54145 was acted upon. > Transaction: Ticket created by CSJEWELL > Queue: PAR-Dist > Subject: PAR::Dist does not try to verify that "Build" is not a > directory > before trying to execute it. > Broken in: 0.46, 0.47 > Severity: Normal > Owner: Nobody > Requestors: csjewell@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=54145 > > > > This issue makes it impossible to package the current version of Wx > (0.96), as it includes a "build" directory, as per the output below. > > [output starts after "perl Makefile.PL" has been executed in that > directory.] > > This should be simple enough to fix that I can send a patch, if you'd > like and if it'd get fixed even faster. > > C:\Wx-0.96>perl -MPAR::Dist -eblib_to_par > Can't open perl script "Build": Permission denied > No such file or directory at C:/strawberry/perl/site/lib/PAR/Dist.pm > line 169. > > C:\Wx-0.96>dir B* > Volume in drive C has no label. > Volume Serial Number is 6C4E-EE8B > > Directory of C:\Wx-0.96 > > 01/29/2010 11:37 PM <DIR> build > 0 File(s) 0 bytes > 1 Dir(s) 2,455,281,664 bytes free
Damn case insensitive file systems :) I'd appreciate a patch. This weekend is quite busy, but I promise I'll try to apply&release next week. Thanks for bringing this up! Best regards, Steffen
Download (untitled) / with headers
text/plain 174b
Sorry for taking so long, but I finally got the patch made. It's an "applypatch" patch, but you can just use "patch" as normal - you don't neccessarily NEED applypatch.
Subject: PAR-Dist-0.47.patch
Download PAR-Dist-0.47.patch
text/x-diff 2.9k
# This is a patch for PAR-Dist-0.47 to update it to PAR-Dist-0.47-patched # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -c "PAR-Dist-0.47\lib\PAR\Dist.pm" "PAR-Dist-0.47-patched\lib\PAR\Dist.pm" Index: ./lib/PAR/Dist.pm *** ./lib/PAR/Dist.pm Sun Nov 29 04:37:22 2009 --- ./lib/PAR/Dist.pm Tue Feb 16 10:54:44 2010 *************** *** 4,10 **** require Exporter; use vars qw/$VERSION @ISA @EXPORT @EXPORT_OK $DEBUG/; ! $VERSION = '0.47'; # Change version in POD, too! @ISA = 'Exporter'; @EXPORT = qw/ blib_to_par --- 4,10 ---- require Exporter; use vars qw/$VERSION @ISA @EXPORT @EXPORT_OK $DEBUG/; ! $VERSION = '0.47_01'; # Change version in POD, too! @ISA = 'Exporter'; @EXPORT = qw/ blib_to_par *************** *** 294,300 **** } sub _build_blib { ! if (-e 'Build') { _system_wrapper($^X, "Build"); } elsif (-e 'Makefile') { --- 294,300 ---- } sub _build_blib { ! if (-e 'Build' and not -d 'Build') { _system_wrapper($^X, "Build"); } elsif (-e 'Makefile') { #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Tue Feb 16 11:03:20 2010 # Generated by : makepatch 2.04 # Recurse directories : Yes # Excluded files : (\A|/).*\~\Z # (\A|/).*\.a\Z # (\A|/).*\.bak\Z # (\A|/).*\.BAK\Z # (\A|/).*\.elc\Z # (\A|/).*\.exe\Z # (\A|/).*\.gz\Z # (\A|/).*\.ln\Z # (\A|/).*\.o\Z # (\A|/).*\.obj\Z # (\A|/).*\.olb\Z # (\A|/).*\.old\Z # (\A|/).*\.orig\Z # (\A|/).*\.rej\Z # (\A|/).*\.so\Z # (\A|/).*\.Z\Z # (\A|/)\.del\-.*\Z # (\A|/)\.make\.state\Z # (\A|/)\.nse_depinfo\Z # (\A|/)core\Z # (\A|/)tags\Z # (\A|/)TAGS\Z # p "lib/PAR/Dist.pm" 42677 1266342884 0100666 #### End of ApplyPatch data #### #### End of Patch kit [created: Tue Feb 16 11:03:20 2010] #### #### Patch checksum: 72 2251 3088 #### #### Checksum: 90 2945 60397 ####


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.