Skip Menu |

This queue is for tickets about the ShipIt CPAN distribution.

Report information
The Basics
Id: 54127
Status: new
Priority: 0/
Queue: ShipIt

Owner: Nobody in particular
Requestors: bobtfish [...]

Bug Information
Severity: Normal
Broken in: 0.53
Fixed in: (no value)


Subject: ShipIt::Step::AddToSVNDir should work with relative to ~ paths
Download (untitled) / with headers
text/plain 237b
The step ShipIt::Step::AddToSVNDir doesn't allow relative to ~ paths like ShipIt::Step::MakeDist does. Please find attached a trivial patch to correct this. I'd be most grateful if it could be included in the next version. Thanks t0m
Subject: shipit-addtosvndir-relpaths.patch
Index: lib/ShipIt/Step/ =================================================================== --- lib/ShipIt/Step/ (revision 24390) +++ lib/ShipIt/Step/ (revision 24391) @@ -30,6 +30,7 @@ sub init { my ($self, $conf) = @_; $self->{dir} = $conf->value("AddToSVNDir.dir"); + $self->{dir} =~ s/^~/$ENV{HOME}/; die "AddToSVNDir.dir not defined in config." unless $self->{dir}; die "AddToSVNDir.dir's value isn't a directory." unless -d $self->{dir}; die "AddToSVNDir.dir's value isn't an svn directory." unless -d "$self->{dir}/.svn";

This service is sponsored and maintained by Best Practical Solutions and runs on infrastructure.

Please report any issues with to