Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 54063
Status: resolved
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: GHENRY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.08115
Fixed in: 0.08121



Subject: create_ddl_dir - slightly misleading
Download (untitled) / with headers
text/plain 348b
sub create_ddl_dir { my ($self, $schema, $databases, $version, $dir, $preversion, $sqltargs) = @_; if(!$dir || !-d $dir) { carp "No directory given, using ./\n"; $dir = "./"; } I think this should say: carp "No directory given or directory does not exist, using ./ instead\n"; I though it would create what I passed in. Thanks.
Download (untitled) / with headers
text/plain 584b
On Thu Jan 28 10:28:26 2010, GHENRY wrote: Show quoted text
> sub create_ddl_dir { > my ($self, $schema, $databases, $version, $dir, $preversion, > $sqltargs) = @_; > > if(!$dir || !-d $dir) { > carp "No directory given, using ./\n"; > $dir = "./"; > } > > > > I think this should say: > > carp "No directory given or directory does not exist, using ./ instead\n"; > > I though it would create what I passed in. > > Thanks.
Fixed in a slightly different way: http://dev.catalystframework.org/svnweb/bast/revision?rev=8906#diff__DBIx-Class_0.08_trunk_lib_DBIx_Class_Storage_DBI.pm
DBIC 0.08121 shipped containing a fix for this bug.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.