Skip Menu |
 

This queue is for tickets about the Gitalist CPAN distribution.

Report information
The Basics
Id: 53934
Status: resolved
Priority: 0/
Queue: Gitalist

People
Owner: BROQ [...] cpan.org
Requestors: BROQ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.000005
Fixed in: (no value)



Subject: Blobs render binary literally
Download (untitled) / with headers
text/plain 464b
When viewing blobs which are binary files e.g /root/static/logo.png, Gitalist renders the binary literally. Unless a plugin steps in[1] to handle the binary data (or any kind for that matter) a /raw link to the file should be generated with the notice that it's a binary file and Gitalist doesn't know how to render arbitrary data. Dan Brook [1] We don't have any such plugin mechanism at the moment, but when we do it'll be handy for situations like this.
Download (untitled) / with headers
text/plain 572b
On Sat Jan 23 03:48:48 2010, BROQ wrote: Show quoted text
> When viewing blobs which are binary files e.g /root/static/logo.png, > Gitalist renders the binary literally. > > Unless a plugin steps in[1] to handle the binary data (or any kind for > that matter) a /raw link to the file should be generated with the
notice Show quoted text
> that it's a binary file and Gitalist doesn't know how to render
arbitrary Show quoted text
> data.
Or I could just implement the functionality as I have done so here: http://github.com/broquaint/Gitalist/commit/e172b6b86d415fbe6137dd8ca4ef 7dc6919f61ba -- Cheers, Dan Brook


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.