Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the IO-Tty CPAN distribution.

Report information
The Basics
Id:
53883
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
TODDR [...] cpan.org
Requestors:
njh [...] bandsman.co.uk
Cc:
AdminCc:

BugTracker
Severity:
Important
Broken in:
1.08
Fixed in:
1.08_02



Subject: IO::Tty on BeOS w/fix
IO::Tty looks in the wrong place for ptys on BSD. This patch fixes the bug: *** OTty.xs Thu Jan 21 14:39:01 2010 --- Tty.xs Thu Jan 21 14:41:25 2010 *************** *** 710,715 **** --- 710,730 ---- if (*ptyfd >= 0 && open_slave(ptyfd, ttyfd, namebuf, namebuflen)) break; + /* Try BeOS style naming */ + sprintf(buf, "/dev/pt/%c%c", + ptymajors[i / num_minors], + ptyminors[i % num_minors]); + sprintf(tbuf, "/dev/tt/%c%c", + ptymajors[i / num_minors], + ptyminors[i % num_minors]); + if (strlcpy(namebuf, tbuf, namebuflen) >= namebuflen) { + warn("ERROR: pty_allocate: ttyname truncated"); + return 0; + } + *ptyfd = open(buf, O_RDWR | O_NOCTTY); + if (*ptyfd >= 0 && open_slave(ptyfd, ttyfd, namebuf, namebuflen)) + break; + /* Try z/OS style naming */ sprintf(buf, "/dev/ptyp%04d", i); sprintf(tbuf, "/dev/ttyp%04d", i);
Am Do 21. Jan 2010, 10:03:54, njh@bandsman.co.uk schrieb:
Show quoted text
> IO::Tty looks in the wrong place for ptys on BSD. This patch fixes
the bug: Thanks a lot, I'll add that with the next release. Roland -- RGiersig@cpan.org
Subject: Re: [rt.cpan.org #53883] IO::Tty on BeOS w/fix
Date: Fri, 21 May 2010 08:59:12 -0400
To: bug-IO-Tty@rt.cpan.org
From: Nigel Horne <njh@bandsman.co.uk>
On 05/21/2010 06:09 AM, Roland Giersig via RT wrote:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=53883> > > Am Do 21. Jan 2010, 10:03:54, njh@bandsman.co.uk schrieb: >
>> IO::Tty looks in the wrong place for ptys on BSD. This patch fixes >>
> the bug: > > Thanks a lot, I'll add that with the next release. >
Oops - I meant BeOS not BSD! -Nigel
From: njh@bandsman.co.uk
Any chance this will happen soon? I'm playing with Perl 5.12.1, and it has the same problem which needs to have my patch.
Am Do 26. Aug 2010, 17:13:29, njh@bandsman.co.uk schrieb:
Show quoted text
> Any chance this will happen soon? I'm playing with Perl 5.12.1, and it > has the same problem which needs to have my patch. >
Sorry, I'm on a tight schedule for the next few weeks, maybe october. -- RGiersig@cpan.org
Presently the only Haiku test report shows as a failure. http://www.cpantesters.org/cpan/report/18395b14-bd87-11df-8246-59ba6e8696e0
This was patched in 1.08_02 but the Haiku test suite seems to continue to be failing.
1.09 was released with this fix. I see nothing to indicate this is going to be a problem in the test suites.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.