Skip Menu |
 

This queue is for tickets about the IO CPAN distribution.

Report information
The Basics
Id: 53770
Status: resolved
Priority: 0/
Queue: IO

People
Owner: Nobody in particular
Requestors: STEFFENW [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.25
Fixed in: (no value)



Subject: binmode does not accept 1 or 2 parameters but this are the typical calls.
Download (untitled) / with headers
text/plain 177b
Please change IO::File 1.14 from 0196: ( @_ == 1 or @_ == 2 ) or croak 'usage $fh->binmode([LAYER])'; to 0196: ( @_ == 1 && @_ == 2 ) or croak 'usage $fh->binmode([LAYER])';
Download (untitled) / with headers
text/plain 127b
And there is a second problem with sub binmode. The closing bracket at the end of th sub is missing. This locks like untested.
Download (untitled) / with headers
text/plain 112b
Ignore the 2nd. I have no idea why I could not see the bracket. At the current version the bracket was written.
Subject: Re: [rt.cpan.org #53770] binmode does not accept 1 or 2 parameters but this are the typical calls.
Date: Mon, 18 Jan 2010 14:33:39 -0600
To: bug-IO [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
Download (untitled) / with headers
text/plain 316b
On Jan 17, 2010, at 1:43 AM, Steffen Winkler via RT wrote: Show quoted text
> > Please change IO::File 1.14 from > > 0196: ( @_ == 1 or @_ == 2 ) or croak 'usage $fh->binmode([LAYER])'; > > to > > 0196: ( @_ == 1 && @_ == 2 ) or croak 'usage $fh->binmode([LAYER])';
Did you test this ? that will croak one EVERY call Graham.
Excuse me. Maybe I lost my brain.
Ticket migrated to github as https://github.com/toddr/IO/issues/37


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.