Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 53394
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: tomita [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.70
Fixed in: (no value)



Subject: parser options are ignored
 Hi

some parser options are ignored by XML::LibXML->new(some options), XML::LibXML->load_xml(some options).

see "parser_options.t"

"parser_options.patch" is one of the solution. 

regards

--
Tomita
Subject: parser_options.t
Download parser_options.t
text/x-perl 390b
use strict; use warnings; use Test::More tests => 2; use XML::LibXML; my $by_accessor = XML::LibXML->new; $by_accessor->recover(1); my $by_args = XML::LibXML->new( recover => 1, ); is $by_accessor->{XML_LIBXML_RECOVER}, $by_args->{XML_LIBXML_RECOVER}, "good"; is $by_accessor->{XML_LIBXML_PARSER_OPTIONS}, $by_args->{XML_LIBXML_PARSER_OPTIONS}, "NG v1.70";
Subject: parser_options.patch
--- LibXML.pm 2010-01-05 18:55:30.000000000 +0900 +++ LibXML.pm.new 2010-01-05 18:54:58.000000000 +0900 @@ -363,7 +363,7 @@ $opts{no_blanks} = !$opts{keep_blanks} if exists($opts{keep_blanks}) and !exists($opts{no_blanks}); for (keys %OUR_FLAGS) { - $self->{$OUR_FLAGS{$_}} = delete $opts{$_}; + $self->{$OUR_FLAGS{$_}} = $opts{$_}; } $class->load_catalog(delete($opts{catalog})) if $opts{catalog};
Download (untitled) / with headers
text/plain 726b
Hi Tomita, On Tue Jan 05 05:25:16 2010, TOMITA wrote: Show quoted text
> Hi > > some parser options are ignored by XML::LibXML->new(some options), > XML::LibXML->load_xml(some options). > > see "parser_options.t" > > "parser_options.patch" is one of the solution. > > regards >
Thanks for the report, and sorry for the late response - it's just that the previous maintainer lacked time, and I only started maintaining XML::LibXML a few weeks ago. Now, I can see your test failing, but can you demonstrate a more meaningful mis-behaviour? Something that fails to work properly, but should succeed. If you can give a .t test file (using Test::More as the previous one) that does that, then I'll applying it. Regards, -- Shlomi Fish
ty for reply and maintaining. I apologize for my unclear report. I found this point during development Template::Semantic. But now, I do not remember what the problem is... sorry. If I found the point then I will report back. I say thank you again for your maintaining work. -- Tomita On 2011-6月-29 水 13:17:53, SHLOMIF wrote: Show quoted text
> Hi Tomita, > > On Tue Jan 05 05:25:16 2010, TOMITA wrote:
> > Hi > > > > some parser options are ignored by XML::LibXML->new(some options), > > XML::LibXML->load_xml(some options). > > > > see "parser_options.t" > > > > "parser_options.patch" is one of the solution. > > > > regards > >
> > Thanks for the report, and sorry for the late response - it's just
that Show quoted text
> the previous maintainer lacked time, and I only started maintaining > XML::LibXML a few weeks ago. > > Now, I can see your test failing, but can you demonstrate a more > meaningful mis-behaviour? Something that fails to work properly, but > should succeed. > > If you can give a .t test file (using Test::More as the previous one) > that does that, then I'll applying it. > > Regards, > > -- Shlomi Fish >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.