Skip Menu |
 

This queue is for tickets about the Sys-Syslog CPAN distribution.

Report information
The Basics
Id: 53317
Status: resolved
Priority: 0/
Queue: Sys-Syslog

People
Owner: Nobody in particular
Requestors: perl [...] profvince.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.28



Subject: t/constant.t is skipped under PERL_CORE
In the core, tests are now run directly from the Sys-Syslog subdirecty, just like when one install it from CPAN. Hence the path to macros.all file doesn't need to be special cased anymore when PERL_CORE is set. Moreoever, it was pointing to the old path (in ext/, while Sys::Syslog is now in cpan/) and t/constant.t was skipped in core. Patch attached.

Vincent.

Subject: sys-syslog-perl_core.patch
--- t/constants.t +++ t/constants.t @@ -4,8 +4,7 @@ use File::Spec; use Test::More; # NB. For PERL_CORE to be set, taint mode must not be enabled -my $macrosall = $ENV{PERL_CORE} ? File::Spec->catfile(qw(.. ext Sys-Syslog macros.all)) - : 'macros.all'; +my $macrosall = 'macros.all'; open(MACROS, $macrosall) or plan skip_all => "can't read '$macrosall': $!"; my @names = map {chomp;$_} <MACROS>; close(MACROS);
Subject: Re: [rt.cpan.org #53317] t/constant.t is skipped under PERL_CORE
Date: Sun, 17 Apr 2011 09:50:37 +0200
To: bug-Sys-Syslog [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
Download (untitled) / with headers
text/plain 599b
Vincent Pit wrote via RT: Show quoted text
> In the core, tests are now run directly from the Sys-Syslog > subdirecty, just > like when one install it from CPAN. Hence the path to macros.all > file doesn't > need to be special cased anymore when PERL_CORE is set. Moreoever, > it was > pointing to the old path (in ext/, while Sys::Syslog is now in > cpan/) and > t/constant.t was skipped in core. Patch attached.
Thanks, applied. Apologies for the delay. Included with release 0.28, sponsored by the Perl QA Hackathon 2011 in Amsterdam. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.