Skip Menu |
 

This queue is for tickets about the Font-AFM CPAN distribution.

Report information
The Basics
Id: 53295
Status: open
Priority: 0/
Queue: Font-AFM

People
Owner: Nobody in particular
Requestors: tom.browder [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.20
Fixed in: (no value)



Subject: Bug with Glyph Names with Embedded Periods (Dots)
Fonts with glyph names like "b_b.alt1" (containing an embedded dot as in Adobe's BickhamScriptPro-Bold) are not parsed properly with the current version (1.20) of Font::AFM.

The problem line is line 264 which currently reads:

  my($name) = /\bN\s+(\.?\w+)\s*;/;

The immediate fix is to change the line to read:

  my($name) = /\bN\s+(\.?\w+\.?\w*)\s*;/;

I have been working on other enhancements and clean ups which I will post separately a little later with a patch to the current version.

Thanks.  I would like something in the tests to be updated as well.  If you can look into that as well it would be great.

You can check out the real history and sources at <http://github.com/gisle/font-afm&gt;.  That's if you don't mind learning something about git as you go.
Subject: Re: [rt.cpan.org #53295] Bug with Glyph Names with Embedded Periods (Dots)
Date: Mon, 4 Jan 2010 11:37:50 -0600
To: bug-Font-AFM [...] rt.cpan.org
From: Tom Browder <tom.browder [...] gmail.com>
Download (untitled) / with headers
text/plain 513b
On Mon, Jan 4, 2010 at 11:26, Gisle_Aas via RT <bug-Font-AFM@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=53295 > > > Thanks. I would like something in the tests to be updated as well. If you can > look into that as well it would be great. > > You can check out the real history and sources at > <http://github.com/gisle/font-afm>. That's if you don't mind learning something > about git as you go.
I'll do that. And how shall I handle my proposed patch when I finish? Regards, -Tom
If you have commited your proposed patch to your local git repo you can use the 'git format-patch' command to generate files you can attach to the rt.cpan.org ticket.  That way when I apply it author information and commit message is automatically included.

If you create your own github account you can also just send me a reference to your github branch and I can pull down the patches directly from there.
 
Subject: Re: [rt.cpan.org #53295] Bug with Glyph Names with Embedded Periods (Dots)
Date: Mon, 4 Jan 2010 13:21:44 -0600
To: bug-Font-AFM [...] rt.cpan.org
From: Tom Browder <tom.browder [...] gmail.com>
Download (untitled) / with headers
text/plain 724b
On Mon, Jan 4, 2010 at 12:00, Gisle_Aas via RT <bug-Font-AFM@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=53295 > > > If you have commited your proposed patch to your local git repo you can use the > 'git format-patch' command to generate files you can attach to the rt.cpan.org > ticket. That way when I apply it author information and commit message is > automatically included.
Great. One more question, for the immediate bug fix test shall I use a fake afm file or shall I provide the real thing. I have already run "make_metrics" with my afm in its usual place and the corresponding pm file was generated in the Metrics directory of the font-afm git source tree--is that good enough? -Tom


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.