Skip Menu |
 

This queue is for tickets about the DBIx-SearchBuilder CPAN distribution.

Report information
The Basics
Id: 5324
Status: resolved
Priority: 0/
Queue: DBIx-SearchBuilder

People
Owner: Nobody in particular
Requestors: rg [...] progtech.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
DBIx-SearchBuilder.patch



Date: Fri, 13 Feb 2004 20:30:52 +0100
From: Rolf Grossmann <rg [...] progtech.net>
To: Jesse Vincent <jesse [...] bestpractical.com>
Subject: Bug in DBIx::SearchBuilder
Download (untitled) / with headers
text/plain 853b
Hi Jesse, Jesse Vincent wrote: Show quoted text
> RT 3.0.9 requires DBIx::SearchBuilder 0.97 which was just released to > CPAN. This version is identical to the 0.97_02 development release.
There's a bug in DBIx::SearchBuilder that I've been meaning to tell you (but forgot, sorry). Remembered from this mail and it's still present. Goes as this: The _gen_alternate_cache_key function does not handle values that include a operator (and are therefore perl HASHes). As a result, the generated key contains the hashes memory address instead of the value, which for me resulted in some funny non-deterministic behaviour when adresses for different objects were hit. Possible patch is attached (and I hope that will make things clearer than my description). I haven't checked if that is the only time the value is used like that, it did fix my problem. Rolf
--- /usr/ports/databases/p5-DBIx-SearchBuilder/work/DBIx-SearchBuilder-0.96/SearchBuilder/Record/Cachable.pm Fri Jan 2 22:55:29 2004 +++ /usr/dist/local/lib/perl5/site_perl/5.8.2/DBIx/SearchBuilder/Record/Cachable.pm Wed Jan 28 20:39:01 2004 @@ -257,6 +257,7 @@ my ($this, %attr) = @_; my $cache_key=$this->Table() . ':'; while (my ($key, $value) = each %attr) { + if (ref($value) eq "HASH") { $value = $value->{value}; } $cache_key .= ($key ||'__undef'). '=' . ($value||'__undef') . ','; } chop ($cache_key);
From: stephen [...] jadevine.org.uk
Download (untitled) / with headers
text/plain 310b
This patch makes a huge difference to me, with logging on i get 350 lines of logged queries pre-patch and 155 post-patch for displaying the same ticket. This is on Debian unstable, postgres 7.4.1, perl 5.8.3, rt 3.0.9 I hope this makes it into a release of DBIx::SBr sometime soon. Thanks, Stephen Quinney
Download (untitled) / with headers
text/plain 426b
[guest - Fri Feb 20 11:44:43 2004]: Show quoted text
> This patch makes a huge difference to me, with logging on i get 350 > lines of logged queries pre-patch and 155 post-patch for displaying the > same ticket. > > This is on Debian unstable, postgres 7.4.1, perl 5.8.3, rt 3.0.9 > > I hope this makes it into a release of DBIx::SBr sometime soon. >
Appears to have been applied forever ago. resolving. Show quoted text
> Thanks, > > Stephen Quinney


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.