Skip Menu |
 

This queue is for tickets about the Net-Ping CPAN distribution.

Report information
The Basics
Id: 52979
Status: open
Priority: 0/
Queue: Net-Ping

People
Owner: Nobody in particular
Requestors: toddr [...] null.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.36
Fixed in: (no value)



Subject: Net::Ping tests fail under fakeroot
Download (untitled) / with headers
text/plain 122b
Need to add check to appropriate tests to skip if in fakeroot since there won't be sufficient privileges. Patch provided
Subject: t_net_ping_icmp.patch
Download t_net_ping_icmp.patch
text/x-diff 1009b
diff --git a/lib/Net/Ping/t/110_icmp_inst.t b/lib/Net/Ping/t/110_icmp_inst.t index 14a7f12..d77f1f0 100755 --- a/lib/Net/Ping/t/110_icmp_inst.t +++ b/lib/Net/Ping/t/110_icmp_inst.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS' and $^O ne 'cygwin') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok !!$p; diff --git a/lib/Net/Ping/t/500_ping_icmp.t b/lib/Net/Ping/t/500_ping_icmp.t index db20ac9..8884577 100755 --- a/lib/Net/Ping/t/500_ping_icmp.t +++ b/lib/Net/Ping/t/500_ping_icmp.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok $p->ping("127.0.0.1");
Download (untitled) / with headers
text/plain 118b
Sorry, The patches provided patch perl 5.10 dist. You'll need to correct the file paths in the patch for this module.
From: toddr [...] null.net
Attaching corrected patch
diff --git a/lib/Net/Ping/t/110_icmp_inst.t b/lib/Net/Ping/t/110_icmp_inst.t index 14a7f12..d77f1f0 100755 --- a/t/110_icmp_inst.t +++ b/t/110_icmp_inst.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS' and $^O ne 'cygwin') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) { + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok !!$p; diff --git a/lib/Net/Ping/t/500_ping_icmp.t b/lib/Net/Ping/t/500_ping_icmp.t index db20ac9..8884577 100755 --- a/lib/Net/Ping/t/500_ping_icmp.t +++ b/lib/Net/Ping/t/500_ping_icmp.t @@ -23,6 +23,8 @@ if (($> and $^O ne 'VMS') skip "icmp ping requires root privileges.", 1; } elsif ($^O eq 'MacOS') { skip "icmp protocol not supported.", 1; +} elsif ($ENV{'FAKEROOTKEY'}) { + skip "icmp tests not supported under fakeroot", 1; } else { my $p = new Net::Ping "icmp"; ok $p->ping("127.0.0.1");


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.