Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the PathTools CPAN distribution.

Report information
The Basics
Id: 52165
Status: rejected
Priority: 0/
Queue: PathTools

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: File::Spec::Unix::canonpath should concatenate, not interpolate, return value
Download (untitled) / with headers
text/plain 380b
The last line is: return "$node$path"; Since I believe concatenation should always be faster than interpolation, it should be changed to: return $node. $path; Since canonpath is a hot-spot that is called frequently in the code (e.g. in catdir and catfile), this should deliver some slight performance improvement for code that makes heavy use of File::Spec. -- David
Subject: Re: [rt.cpan.org #52165] AutoReply: File::Spec::Unix::canonpath should concatenate, not interpolate, return value
Date: Sun, 29 Nov 2009 01:01:58 -0500
To: bug-PathTools [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 250b
On further examination, this should largely be optimized away by the interpreter. (I seem to have suffered from a benchmark that was influenced by system load -- and unfortunately in the direction I was expecting.) Feel free to disregard. -- David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.