Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Notify CPAN distribution.

Report information
The Basics
Id: 52121
Status: stalled
Priority: 0/
Queue: SVN-Notify

People
Owner: Nobody in particular
Requestors: teguheko [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.79
Fixed in: (no value)



Subject: HTML output with CSS inline
Download (untitled) / with headers
text/plain 766b
In my company, we are using Google apps Gmail interface to receive emails. Using the current output of SVN::Notify::HTML and SVN::Notify::HTML::ColorDiff, the HTML can not be rendered properly because of the nature of the web email. To fix that, the CSS need to be put inline in the HTML tags. I made a patch to receive css-inline parameter. But, the code is still kind of dirty, checking for each HTML string and if the parameter defined, I put the CSS inside the HTML tag. The code was a modification from http://www.jaim.at/2008/09/06/jack-moffitt-power-up-your-commit-e-mails/ Other alternative I can think of is to have a CSS inline converter which will get the HTML output and just convert the embedded CSS to be inline on the fly before sending the email.
Subject: HTML.pm
Download HTML.pm
text/x-perl 24k

Message body is not shown because it is too large.

Subject: ColorDiff.pm
Download ColorDiff.pm
text/x-perl 12k

Message body is not shown because it is too large.

From: Stephen J. Fuhry
Download (untitled) / with headers
text/plain 206b
Are there any plans to integrate this patch into a future release? I would love to have this feature, but I'd rather not patch up my production server if it will be implemented in a future release anyways.
Subject: Re: [rt.cpan.org #52121] HTML output with CSS inline
Date: Fri, 14 Jan 2011 10:42:49 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: "David E. Wheeler" <david [...] kineticode.com>
Download (untitled) / with headers
text/plain 921b
On Dec 16, 2010, at 3:57 PM, https://www.google.com/accounts/o8/id?id=AItOawnpGfTTHA19URX26usctWK3ag2xyoaTiPs via RT wrote: Show quoted text
> Queue: SVN-Notify > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=52121 > > > Are there any plans to integrate this patch into a future release? > > I would love to have this feature, but I'd rather not patch up my > production server if it will be implemented in a future release anyways.
I hadn't planned to, no, because it could pretty easily be implemented as a filter. http://p3rl.org/SVN::Notify::Filter That said, if it makes the display better in Web mail clients, perhaps we should instead just always change it to be inline CSS. Do we really need two different ways of formatting things? I think I'd rather have it all be done in one way. Care to take a stab at implementing that? Patch based on https://svn.kineticode.com/SVN-Notify/trunk Thanks, David
Download (untitled) / with headers
text/plain 864b
On Fri Jan 14 13:42:57 2011, david@kineticode.com wrote: Show quoted text
> > Are there any plans to integrate this patch into a future release? > > > > I would love to have this feature, but I'd rather not patch up my > > production server if it will be implemented in a future release
> anyways. > > I hadn't planned to, no, because it could pretty easily be implemented > as a filter. > > http://p3rl.org/SVN::Notify::Filter > > That said, if it makes the display better in Web mail clients, perhaps > we should instead just always change it to be inline CSS. Do we > really need two different ways of formatting things? I think I'd > rather have it all be done in one way. > > Care to take a stab at implementing that? Patch based on > > https://svn.kineticode.com/SVN-Notify/trunk
Now moved here: https://github.com/theory/svn-notify/ Best, David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.